Community
Participate
Working Groups
In a workspace in a directory with a space in its name where I have only ever installed version 2.0.1.I20130712-2204 of Gerrit, when I query it creates a directory with the same path but with the space replaced with a %20 containing .metadata\.mylyn\reviews_bin. E.g. if my workspace path is C:\test eclipses\workspace1 I get a C:\test%20eclipses\workspace1 directory.
That's not good. We need to fix the Ecore URL encoding. I thought we already had a test for this, but I guess not...
Ok, I'm able to reproduce, but only for the special case where the space is in the first level directory. If I do e.g. C:\Users\Miles Parker\blah it works as expected. That must have been the case that was already handled that I was thinking of.
Note that this only appears to break in Windows, not Mac.
https://git.eclipse.org/r/14990 As I step through execution, this could also explain some other anomalies, as when we get the resource the code thinks it doesn't exist and we need to keep recreating the resource over and over. (EMF does *find* the resource in the correct place, it's the connector code that's getting the path right.) Note that you shouldn't actually have anything in that directory, and you *should* have a directory C:\test eclipses\workspace1\.metadata\.mylyn\reviews_bin that contains the files, correct? Sam, do you often actually have this case where the first segment includes spaces?
Note that I haven't thought of a really good way to test this *specific* case, because I don't think I can use a root directory for the tests and this only appears to happen on Windows which isn't unit tested anyway.
Ok, I've put it under testing now. On further investigation, this seems to happen regardless of where the spaces are in the path, and regardless of Operating System. I think it's also likely that this was the original cause for a number of recent bugs, including bug 413363 and bug 413362 and might explain why some issues seemed reproducible and others didn't. Nice find, Sam. Thanks!
(In reply to comment #4) > Sam, do you often actually have this case where the first segment includes > spaces? I always have this case when testing by installing a build into eclipse. I don't have this case in my normal development and testing workspaces.
Merged https://git.eclipse.org/r/14990.
*** Bug 413363 has been marked as a duplicate of this bug. ***
