Bug 413492 - [Contributions] [e4] Multiple trim widgets appear
Summary: [Contributions] [e4] Multiple trim widgets appear
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5.1   Edit
Hardware: PC Windows 7
: P3 major with 4 votes (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
: 435267 449470 (view as bug list)
Depends on:
Blocks: 549902
  Show dependency tree
 
Reported: 2013-07-23 03:02 EDT by Eike Stepper CLA
Modified: 2021-08-02 06:06 EDT (History)
10 users (show)

See Also:


Attachments
Screenshot (5.44 KB, image/png)
2013-07-23 03:03 EDT, Eike Stepper CLA
no flags Details
Bottom window trim: duplicate working set and active task (2.25 KB, image/png)
2016-03-03 14:55 EST, Jörg Thönnes CLA
no flags Details
workbench.xmi with duplication (1024.00 KB, text/x-xmi)
2016-03-23 04:59 EDT, Neale Upstone CLA
no flags Details
Screen shot of duplicate trims for both the active task and working set window trims (2.32 KB, image/png)
2016-03-23 10:02 EDT, Jörg Thönnes CLA
no flags Details
workbench.xmi for the screen shot (825.33 KB, text/plain)
2016-03-23 10:28 EDT, Jörg Thönnes CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Stepper CLA 2013-07-23 03:02:49 EDT
I'm using e4 with Mylyn from Kepler (3.10?). I'm going to attach a screenshot...
Comment 1 Eike Stepper CLA 2013-07-23 03:03:31 EDT
Created attachment 233691 [details]
Screenshot
Comment 2 Eike Stepper CLA 2013-07-29 04:02:09 EDT
Now I've got 5 of them ;-(

Soon there won't be any space left in the status line...
Comment 3 Eike Stepper CLA 2013-07-29 04:03:19 EDT
I get the feeling that each time I kill the eclipse process (because once more it's indefinitely frozen for background activity taht can't be canceled) te next restart adds one more trim widget.
Comment 4 Levi Purvis CLA 2013-08-23 14:18:12 EDT
I'm seeing the same thing in the JEE flavor of Kepler on Linux (Kubuntu).

(In reply to comment #3)
> I get the feeling that each time I kill the eclipse process (because once
> more it's indefinitely frozen for background activity taht can't be
> canceled) te next restart adds one more trim widget.

You may be on to something.  I've had Eclipse hang on me when using it over NX (x2go.org) - actually Eclipse can freeze up the whole remote X session.  Having to kill the process *might* correspond to when I get duplicates.

Is there any way to disable this trim decoration?  It can be moved like a toolbar, but I don't see a way to hide it in Customize Perspective.
Comment 5 Eike Stepper CLA 2013-08-23 15:44:02 EDT
Not that I think this is a permanent solution but the annoying bug 394386 gave me a hint on how to work around this multiple trim widget problem: 

Save all your perspectives and then open a new workbench window. The new window will be in good shape. You can then close the old bogus window and all is good ;-)
Comment 6 Levi Purvis CLA 2013-08-23 20:03:48 EDT
Thank you!

Also, I had dragged this widget down to the status bar area.  When I moved it back to the toolbar area, I was able to find it in Customize Perspective -> Tool Bar Visibility and hide it.

Oddly, if I messed with Command Groups Availability, the widget would come back (even if still hidden via Tool Bar Visibility).  But, it is properly hidden again after bouncing Eclipse.
Comment 7 Leo Dos Santos CLA 2014-01-10 19:17:50 EST
Is this still a problem with Kepler SR 1? I haven't seen since this problem myself with Kepler.

> Is there any way to disable this trim decoration?  It can be moved like a
> toolbar, but I don't see a way to hide it in Customize Perspective.

You can also disable the trim widget from Preferences -> Mylyn -> Tasks -> "Show active task on window trim"
Comment 8 Eike Stepper CLA 2014-01-11 05:22:50 EST
(In reply to Leo Dos Santos from comment #7)
> Is this still a problem with Kepler SR 1? I haven't seen since this problem
> myself with Kepler.

I don't use Kepler but it's definitely still a problem in Luna M4 ;-(
Comment 9 Sam Davis CLA 2014-01-13 15:50:50 EST
This widget is contributed only through the org.eclipse.ui.menus extension point. The behaviour described sounds like a bug in the platform since I don't see how we could cause or fix this in Mylyn. Moving to Platform; please let us know if there's something we can do to fix this in Mylyn.
Comment 10 Paul Webster CLA 2014-01-24 09:58:43 EST
(In reply to Eike Stepper from comment #8)
> 
> I don't use Kepler but it's definitely still a problem in Luna M4 ;-(

Eike, does it still happen when you have to kill eclipse?

PW
Comment 11 Eike Stepper CLA 2014-01-25 06:51:32 EST
I frequently have to kill Eclipse because EGit freezes during commits. Each time I get one trim widget more. When I disable the trim widget in the Mylyn task preferences, only the last trim widget disappears. All the other ones stay visible. It's pretty annoying because the trim area quickly fills up with garbage ;-(
Comment 12 Declan McAleese CLA 2014-01-30 16:33:15 EST
I'm seeing this in Kepler SR1 and the 4.3 maintenance branch (just reproduced on Windows 7 by killing Eclipse, as described, in M20140129-0800).
Comment 13 Leo Dos Santos CLA 2014-05-23 16:26:26 EDT
*** Bug 435267 has been marked as a duplicate of this bug. ***
Comment 14 Ed Merks CLA 2014-11-22 09:33:21 EST
*** Bug 449470 has been marked as a duplicate of this bug. ***
Comment 15 Neale Upstone CLA 2015-11-27 05:23:33 EST
Hi,

I've just found this bug having originally reported it as an STS bug at https://issuetracker.springsource.com/browse/STS-4075.

I too think it is when the process is killed (in my case I think Ubuntu does that when I shutdown my laptop but without shutting down Eclipse first).

I'm sure that if you took a look at the above issue and the attached workbench.xmi, you'll gain some insights.

Thanks. Neale.
Comment 16 Eike Stepper CLA 2015-12-14 00:44:29 EST
Hello Platform,

is someone working on this bug? It's really a major annoyance and that for more than two years. I know there's a work-around (i.e., create a new window and close the old one), but with that work-around I always lose many window-related settings, for example grouping in Problems view and others. Given how crappy Eclipse starts to look after crashes (see attached screenshot) I increase the severity to major.
Comment 17 Jörg Thönnes CLA 2016-03-03 05:47:54 EST
I also have this issue for a while, both with

- Mylyn: active task on window trim

and

- Tasktop: task workings set on window trim

Since I use task workings sets heavily (at least 4-6 items), I easily get into the situation to have TWO lines in the trim due to duplication.

This is a major annoyance though workarounds exists.

See this stack overflow question:

http://stackoverflow.com/questions/28148801/eclipse-mylyn-window-trim-active-task-displayed-multiple-times

IMHO, this should be far enough information to reproduce and analyse this issue.

At least, I would expect some background from the Eclipse developer why could not be addressed yet.

I would be happy to produce any feedback, do experiments etc.

Eclipse Java EE IDE for Web Developers.
Version: Mars.2 Release (4.5.2)
Build id: 20160218-0600
Comment 18 Jörg Thönnes CLA 2016-03-03 05:52:28 EST
BTW, this is NOT related to killing the process.

To me, it happens if I drag around the trim widgets for Mylyn: active task or Tasktop: Workings set 

The reason why I drag around the trim widget is that the resize does not work:

If I add more and more Mylyn working sets, the trim widget does NOT adapt it size but shortens the entries. Therefore, I drag it around to trigger a resize... and get duplication!

HTH, Jörg
Comment 19 Sam Davis CLA 2016-03-03 12:55:00 EST
Platform team, are there any plans to fix this? This really hampers usability of Eclipse.
Comment 20 Jörg Thönnes CLA 2016-03-03 13:01:44 EST
Sam, are Mylyn or Tasktop using any specific features here which could trigger this kind of behaviour. I.e. could you provide some more details on your implementations if Platform team needs them?
Comment 21 Sam Davis CLA 2016-03-03 14:18:14 EST
Not that I know of. The active task trim is implemented by org.eclipse.mylyn.internal.tasks.ui.TaskTrimWidget and org.eclipse.mylyn.internal.tasks.ui.TaskHistoryDropDown if Platform team wants to look at it.
Comment 22 Jörg Thönnes CLA 2016-03-03 14:20:00 EST
Thanks, Sam.
Comment 23 Jörg Thönnes CLA 2016-03-03 14:55:19 EST
Created attachment 260071 [details]
Bottom window trim: duplicate working set and active task

Here you can see the duplicate window trim widgets 
- the active (task) working set
- the active task
Comment 24 Jörg Thönnes CLA 2016-03-03 14:57:19 EST
I have also noticed triple instances.

The "Add Working Set" part will expand to a couple of working set entries (more than 1) if several Mylyn Task working sets are available.

Just consider you have 4 or 5 task working sets tripled!
Comment 25 Jörg Thönnes CLA 2016-03-15 16:13:44 EDT
Does nobody care about this nasty issue?
Comment 26 Jörg Thönnes CLA 2016-03-22 05:30:22 EDT
If anybody would give me some pointers where to look into the code, I could start checking it myself.
Comment 27 Jörg Thönnes CLA 2016-03-22 05:32:57 EDT
Paul, for me it is NOT triggered by killing Eclipse but just by a plain drag and drop operation.
Comment 28 Neale Upstone CLA 2016-03-22 07:24:35 EDT
Come on Platform folks.  Just some pointers for a pull request would be helpful.  Where's the community engagement?
Comment 29 Brian de Alwis CLA 2016-03-22 13:36:40 EDT
I suspect most platform developers don't use Mylyn, and so it's not a bug that we encounter.  I've tried dragging around the active task bar as described in comment 18 on Neon (4.6) and I can't reproduce the described behaviour.

I could see this happening with killing Eclipse if you have the workbench-autosave enabled (which it is by default) as it will write out the trim contributions into the persisted model.

Could you please verify that this occurs with 4.6M6/Neon?
Could you please attach your <workspace>/.metadata/.plugins/org.eclipse.e4.workbench/workbench.xmi file?
Comment 30 Neale Upstone CLA 2016-03-23 04:59:31 EDT
Created attachment 260512 [details]
workbench.xmi with duplication


This is from an Spring Tool Suite install where the same thing is happening for other plugins such as the terminal.
Comment 31 Jörg Thönnes CLA 2016-03-23 10:02:37 EDT
Created attachment 260525 [details]
Screen shot of duplicate trims for both the active task and working set window trims

Here I would expect
- a window trim widget with one active task entry
- a window trim widget with three task working set entries

But I get both doubled. Sometimes also tripled!
Comment 32 Jörg Thönnes CLA 2016-03-23 10:28:15 EDT
Created attachment 260527 [details]
workbench.xmi for the screen shot

Here is my workbench xmi for the screen shot.
I removed the Persisted state memento since it contained some internal information.
Comment 33 Neale Upstone CLA 2016-03-23 12:15:55 EDT
(In reply to Brian de Alwis from comment #29)
> 
> I could see this happening with killing Eclipse if you have the
> workbench-autosave enabled (which it is by default) as it will write out the
> trim contributions into the persisted model.
> 

By "enabled by default" do you mean that "workspace save interval" is set to 5 minutes?

I'll set mine to longer than a day and see if this stops the issue.
Comment 34 Jörg Thönnes CLA 2016-03-30 11:53:05 EDT
(In reply to comment #33)
> By "enabled by default" do you mean that "workspace save interval" is set to 5
> minutes?
> 
> I'll set mine to longer than a day and see if this stops the issue.

Neal, did it stop the issue for you?
Comment 35 Neale Upstone CLA 2016-03-30 19:25:31 EDT
Unfortunately it hasn't.
Comment 36 Rolf Theunissen CLA 2019-07-16 14:27:34 EDT
WORKAROUND:

To disable automatic saving of the workbench, set the interval to zero:
Set Preferences > General > Workbench save interval (in minutes) to 0
Comment 37 Rolf Theunissen CLA 2019-08-11 14:48:34 EDT
W.r.t. multiplications of tool items after restart, this is handled in Bug 509371.

I cannot reproduce the duplication by dragging around the Mylyn toolbar. Does the duplication by dragging still occur? If so, does it also occur on new workspaces where Eclipse never was killed?
Comment 38 Eclipse Genie CLA 2021-08-02 06:05:49 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 39 Eclipse Genie CLA 2021-08-02 06:06:07 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.