Bug 413479 - NPE setting modification date
Summary: NPE setting modification date
Status: RESOLVED DUPLICATE of bug 413480
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Mylyn Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-22 17:39 EDT by Sam Davis CLA
Modified: 2013-07-30 04:18 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Davis CLA 2013-07-22 17:39:16 EDT 
I got this repeatedly when trying to refresh a review:

Caused by: java.lang.NullPointerException
	at org.eclipse.emf.common.notify.impl.BasicNotifierImpl.eNotify(BasicNotifierImpl.java:374)
	at org.eclipse.mylyn.reviews.internal.core.model.Review.setModificationDate(Review.java:326)
	at org.eclipse.mylyn.internal.gerrit.core.remote.GerritReviewRemoteFactory.updateModel(GerritReviewRemoteFactory.java:209)
	at org.eclipse.mylyn.internal.gerrit.core.remote.GerritReviewRemoteFactory.updateModel(GerritReviewRemoteFactory.java:1)
	at org.eclipse.mylyn.reviews.core.spi.remote.emf.RemoteEmfConsumer.applyModel(RemoteEmfConsumer.java:242)
	at org.eclipse.mylyn.reviews.core.spi.remote.JobRemoteService$3.run(JobRemoteService.java:95)
	at org.eclipse.ui.internal.UILockListener.doPendingWork(UILockListener.java:164)
	at org.eclipse.ui.internal.UISynchronizer$3.run(UISynchronizer.java:158)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
Comment 1 Sam Davis CLA 2013-07-22 17:40:05 EDT 
When I reopen the review now, the summary and attributes are all blank.
Comment 2 Sam Davis CLA 2013-07-22 17:43:10 EDT 
I can reproduce the blank attributes just by refreshing a review and immediatly stopping the refresh job.
Comment 3 Tomasz Zarna CLA 2013-07-24 07:56:50 EDT 
Not sure if this is related, but at least looks similar, found in the log:

Caused by: java.lang.NullPointerException
	at org.eclipse.emf.common.notify.impl.BasicNotifierImpl.eNotify(BasicNotifierImpl.java:374)
	at org.eclipse.mylyn.reviews.internal.core.model.Review.setKey(Review.java:486)
	at org.eclipse.mylyn.internal.gerrit.core.remote.GerritReviewRemoteFactory.createModel(GerritReviewRemoteFactory.java:161)
	at org.eclipse.mylyn.internal.gerrit.core.remote.GerritReviewRemoteFactory.createModel(GerritReviewRemoteFactory.java:1)
	at org.eclipse.mylyn.reviews.core.spi.remote.emf.RemoteEmfConsumer.applyModel(RemoteEmfConsumer.java:221)
	at org.eclipse.mylyn.reviews.core.spi.remote.JobRemoteService$3.run(JobRemoteService.java:95)
	at org.eclipse.ui.internal.UILockListener.doPendingWork(UILockListener.java:164)
	at org.eclipse.ui.internal.UISynchronizer$3.run(UISynchronizer.java:158)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
	... 23 more
Comment 4 Miles Parker CLA 2013-07-29 18:32:42 EDT 
All of the notifier issues are the same. They're related to not registering and de-registering the observers/ (and hence the adapter) properly. I'm noticing all of these occuring around the same date as well. I'm going to look for changes around that time to see if I can find a culprit.
Comment 5 Steffen Pingel CLA 2013-07-30 04:14:11 EDT 
Miles, this error is happening inside EMF. I don't see how this could be related to not de-registering an observer. This looks a concurrency issue to me where the adapter list is modified from the wrong thread and hence the concurrently happening notification fails unless this a bug in the specific version of EMF.
Comment 6 Steffen Pingel CLA 2013-07-30 04:18:10 EDT 
Let's track on bug 413480.

*** This bug has been marked as a duplicate of bug 413480 ***