Community
Participate
Working Groups
Following the (short) discussion on http://dev.eclipse.org/mhonarc/lists/mylyn-dev/msg01847.html: Let's remove unmaintained rome (together with jdom) from Mylyn.
I did some initial investigation: org.eclipse.mylyn.web.tasks looks quite easy - there is only one method in WebRepositoryConnector and does not leak any rome/jdom API. Things are a bit more complicated if it comes to the org.eclipse.mylyn.commons.notifications.feed, because it leeks SyndEntry via getSource.
+1 for removing dependencies on JDOM and ROME. I wouldn't worry about o.e.m.web.tasks initially since it's in the Incubator. Are you building/shipping that Krysztof? For o.e.m.commons.notifications.feed we would have to rewrite the parser. The format of http://www.eclipse.org/mylyn/updates.xml is reasonably straight forward and we can also change it if that makes parsing easier.
I'm not sure if referencing one format is really desired. AFAIK there is RSS 1.0, RSS 2.0 and Atom. I have not studied the differences yet, but found somewhere that 2.0 and Atom are just extensions of 1.0. Do you happen to know if really only one parser will be needed?
https://git.eclipse.org/r/#/c/15041/
Hey Steffen, those tests pass for me locally - could you run them, too? I really have no idea why do they fail.
(In reply to comment #3) > I'm not sure if referencing one format is really desired. AFAIK there is RSS > 1.0, RSS 2.0 and Atom. I have not studied the differences yet, but found > somewhere that 2.0 and Atom are just extensions of 1.0. Do you happen to know if > really only one parser will be needed? I'm okay with limiting notifications parsing to a specific format. We only use it for Task List update notifications so we basically control the format. (For the Generic Web Connector it's a bit different but as said in comment 2 I wouldn't worry about it.) Thanks for the patch. I'll tentatively put this on for 3.10 so we can hopefully resolve this for the next release.
Tomek, Sam, it would be great to get this in for the release.
Tomek, Sam, could you take a look at the latest on https://git.eclipse.org/r/#/c/15041/? It would be great to get this in for 3.10.
The changes were merged. Thanks very much for driving this, Krzysztof!
Steffen, we still have the following line in /org.eclipse.mylyn.commons.notifications.feed/plugin.properties bq. jars.extra.classpath = platform:/plugin/com.sun.syndication Should this be removed? I don't believe it would ever have had any effect anyway since it is supposed to go in build.properties.
That looks like a mistake indeed. Yep, let's remove that bogus entry.
