Comment 1 Tomasz Zarna 2013-07-30 10:29:58 EDT

Review with a warning that 2.7 is not fully supported: https://git.eclipse.org/r/14971

Comment 2 Steffen Pingel 2013-08-13 14:31:57 EDT

I did a local test run against 2.7-rc3 and only had one failure:

junit.framework.AssertionFailedError: expected:<[CommentLink [find=(I[0-9a-f]{8,40}), replace=<a href="#q,$1,n,z">$&</a>], CommentLink [find=(bug\s+)(\d+), replace=<a href="http://bugs.mylyn.org/show_bug.cgi?id=$2">$&</a>], CommentLink [find=([Tt]ask:\s+)(\d+), replace=$1<a href="http://tracker.mylyn.org/$2">$2</a>]]> but was:<null>
	at junit.framework.Assert.fail(Assert.java:47)
	at junit.framework.Assert.failNotEquals(Assert.java:283)
	at junit.framework.Assert.assertEquals(Assert.java:64)
	at junit.framework.Assert.assertEquals(Assert.java:71)
	at org.eclipse.mylyn.gerrit.tests.core.client.GerritClientTest.testRefreshConfigCommentLinks(GerritClientTest.java:116)
...

It looks like configuration for comment links has changed: http://gerrit-documentation.googlecode.com/svn/Documentation/2.7/config-gerrit.html#commentlink

Comment 3 David E. Narvaez 2013-08-16 17:01:33 EDT

Submitted

https://git.eclipse.org/r/#/c/15557/1

for processing the config in Gerrit 2.7

Comment 4 Tomasz Zarna 2013-08-16 18:00:52 EDT

(In reply to comment #3)
> https://git.eclipse.org/r/#/c/15557/1
> for processing the config in Gerrit 2.7

Is it supposed to fix the issue from comment 2?

Comment 5 David E. Narvaez 2013-08-16 23:49:03 EDT

(In reply to comment #4)
> Is it supposed to fix the issue from comment 2?

No, I haven't come accross the comment issue.

Comment 6 David E. Narvaez 2013-08-21 13:09:31 EDT

(In reply to comment #3)
> Submitted
> 
> https://git.eclipse.org/r/#/c/15557/1
> 
> for processing the config in Gerrit 2.7

Will somebody ever review that? Or else, how can I make an update site from my sources so that I can use a Gerrit Review that works with Gerrit 2.7?

Comment 7 Tomasz Zarna 2013-08-26 08:54:24 EDT

(In reply to comment #2)
> I did a local test run against 2.7-rc3 and only had one failure:
> org.eclipse.mylyn.gerrit.tests.core.client.GerritClientTest.testRefreshConfigCommentLinks(GerritClientTest.java:116)
...
> It looks like configuration for comment links has changed:

Filed https://code.google.com/p/gerrit/issues/detail?id=2059 requesting access to commit links config via REST API.

Comment 8 Steffen Pingel 2013-09-10 11:04:32 EDT

Created attachment 235358 [details]
screenshot

Comment 9 Steffen Pingel 2013-09-14 14:44:09 EDT

Gerrit 2.7 is scheduled to be released very soon now according to the Gerrit support forum.

Comment 10 Steffen Pingel 2013-10-05 21:34:11 EDT

Pushed a review to add 2.7 to the test suite: https://git.eclipse.org/r/#/c/17073/.

Comment 11 Steffen Pingel 2013-10-09 14:08:59 EDT

I merged the last change.