Bug 412620 - re-enable GerritUrlHandlerTest.testOpenUrl() test
Summary: re-enable GerritUrlHandlerTest.testOpenUrl() test
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 2.0.1   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-09 15:19 EDT by Tomasz Zarna CLA
Modified: 2013-07-17 07:17 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2013-07-09 15:19:05 EDT 
The test was failing, because it was blocked while calling RemoteUiService.modelExec(Runnable, boolean). If the call was non-blocking you got an error msg saying "Problem while retrieving Gerrit review.: Not Found null," which means that the connector was unable open a review from Gerrit 2.6 (see bug 395059). The test uses a hard-coded [1] fixture pointing to git.eclipse.org [2].

"I'd be helpful to provision a Gerrit instance on the test server that didn't rely on HTTP authentication but also allowed anonymous access so we don't have to rely on Eclipse.org for testing." [3]. Until that happens we should disable the test as Hudson saying -1 for each review isn't very helpful and it makes spotting a real test regression damn hard.

[1] https://git.eclipse.org/c/mylyn/org.eclipse.mylyn.reviews.git/tree/org.eclipse.mylyn.gerrit.tests/src/org/eclipse/mylyn/gerrit/tests/ui/GerritUrlHandlerTest.java#n52
[2] https://git.eclipse.org/c/mylyn/org.eclipse.mylyn.reviews.git/tree/org.eclipse.mylyn.gerrit.tests/src/org/eclipse/mylyn/gerrit/tests/support/GerritFixture.java#n24
[3] bug 411052 comment 29
Comment 1 Tomasz Zarna CLA 2013-07-09 15:22:36 EDT 
Review for disabling the test for the time being: https://git.eclipse.org/r/#/c/14414/
Comment 2 Steffen Pingel CLA 2013-07-13 10:48:59 EDT 
Pushed two reviews to add a test fixture that supports anonymous access and a change for the test to use that:

14504: update Gerrit repositories to 2.4.4, 2.5.6, 2.6.1, 2.7-rc2, https://git.eclipse.org/r/#/c/14504/
14531: re-enable GerritUrlHandlerTest.testOpenUrl() test, https://git.eclipse.org/r/#/c/14531/
Comment 3 Steffen Pingel CLA 2013-07-17 07:17:17 EDT 
The change was merged.