Bug 412496 - disable actions for anonymous (such as patch set actions and add a comment)
Summary: disable actions for anonymous (such as patch set actions and add a comment)
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 7
: P2 major (vote)
Target Milestone: 2.0.1   Edit
Assignee: Miles Parker CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-08 06:51 EDT by Tomasz Zarna CLA
Modified: 2013-07-17 12:44 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2013-07-08 06:51:33 EDT 
Try to add a comment as anonymous user, e.g. for a review from all open changes.

!ENTRY org.eclipse.mylyn.gerrit.core 4 0 2013-07-08 12:47:55.346
!MESSAGE Operation Failed: Not Signed In
!STACK 0
org.eclipse.mylyn.internal.gerrit.core.client.GerritException: Not Signed In
	at org.eclipse.mylyn.internal.gerrit.core.client.JSonSupport.parseResponse(JSonSupport.java:210)
	at org.eclipse.mylyn.internal.gerrit.core.client.GerritService.invoke(GerritService.java:106)
	at $Proxy8.myAccount(Unknown Source)
	at org.eclipse.mylyn.internal.gerrit.core.client.GerritClient$24.execute(GerritClient.java:809)
	at org.eclipse.mylyn.internal.gerrit.core.client.GerritClient.executeOnce(GerritClient.java:909)
	at org.eclipse.mylyn.internal.gerrit.core.client.GerritClient.execute(GerritClient.java:895)
	at org.eclipse.mylyn.internal.gerrit.core.client.GerritClient.getAccount(GerritClient.java:806)
	at org.eclipse.mylyn.internal.gerrit.core.client.GerritClient.saveDraft(GerritClient.java:271)
	at org.eclipse.mylyn.internal.gerrit.core.operations.SaveDraftRequest.execute(SaveDraftRequest.java:63)
	at org.eclipse.mylyn.internal.gerrit.core.operations.SaveDraftRequest.execute(SaveDraftRequest.java:1)
	at org.eclipse.mylyn.internal.gerrit.core.operations.GerritOperation.execute(GerritOperation.java:55)
	at org.eclipse.mylyn.internal.gerrit.core.operations.GerritOperation.run(GerritOperation.java:45)
	at org.eclipse.mylyn.internal.gerrit.ui.GerritReviewBehavior.addComment(GerritReviewBehavior.java:72)
	at org.eclipse.mylyn.internal.reviews.ui.dialogs.AddCommentDialog$1.run(AddCommentDialog.java:118)
	at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121)

The action should be disabled for users who are not logged in.
Comment 1 Miles Parker CLA 2013-07-08 15:01:57 EDT 
We should address this as part of https://git.eclipse.org/r/#/c/14328/.
Comment 2 Miles Parker CLA 2013-07-10 14:59:10 EDT 
https://git.eclipse.org/r/14454
Comment 3 Miles Parker CLA 2013-07-11 13:18:06 EDT 
Tomek, Sam, please review https://git.eclipse.org/r/#/c/14454/ for inclusion in 2.0.1. (It is no longer dependent on https://git.eclipse.org/r/#/c/14294/)
Comment 4 Miles Parker CLA 2013-07-16 19:53:50 EDT 
Steffen et. al. still looking for sign-off on this one.. :)
Comment 5 Steffen Pingel CLA 2013-07-17 07:16:42 EDT 
Please feel free to merge the change.
Comment 6 Miles Parker CLA 2013-07-17 12:44:15 EDT 
Merged: https://git.eclipse.org/r/#/c/14454/