Community
Participate
Working Groups
The ComboViewer as part of the JFace Viewer should support Java Generics. This should be the first viewer to be ported, as subtask of the bug 402445 .
I'm currently working on this Bug at a github repository. https://github.com/Gamma32/eclipse.platform.ui/tree/PlayGroundGenerics I also created a small sample application which sould demonstrate the use of the current changes. https://github.com/Gamma32/de.gammas.JfaceGenericsTest/blob/master/src/de/gammas/JfaceGenericsTest/parts/SamplePart.java
I've uploaded a patch to gerrit: https://git.eclipse.org/r/#/c/14787/ The current changes lead to more compiler warning caused by the generification of some interfaces. I'll fix this warnings with the porting of the other viewers. I'll also update the JUnit Tests and the JFace Snippets. A sample usage is demonstrated here: https://github.com/Gamma32/de.gammas.JfaceGenericsTest/blob/master/src/de/gammas/JfaceGenericsTest/parts/SamplePart.java
I didn't have time for a complete review today. One quick comment is that we will need to be consistent across JFace on the type names we use for generic types. I see you are using E for "model element" which sounds fine. For viewer input, you are using the default 'T' which I think isn't helpful. When there is more than one generic type on a class it helps to give it a more descriptive type name. I propose 'I' for the Viewer input type.
Okay that sounds reasonable. I'll update this tomorrow. Currently this patch mostly supports just the generics on the api side(not internal) to see if this is the right way to implement it.
I changed the Viewer input type to 'I'
I've abandoned my old changes and added a new one: https://git.eclipse.org/r/#/c/14941/
I've released this as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d5c62ff8e7265c5edbee67c8dbe2144cc113baa0 Thanks Hendrik. Can we generify org.eclipse.jface.tests.viewers.ComboViewerTest and org.eclipse.jface.tests.viewers.CComboViewerTest to show how this viewer is now supposed to be used? PW
Hey Paul, thanks for your review. I'll do this tomorrow or on Monday. I'll also update the JFace Snippets (In reply to comment #7) > I've released this as > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=d5c62ff8e7265c5edbee67c8dbe2144cc113baa0 > > Thanks Hendrik. > > Can we generify org.eclipse.jface.tests.viewers.ComboViewerTest and > org.eclipse.jface.tests.viewers.CComboViewerTest to show how this viewer is > now supposed to be used? > > PW
I've uploaded a patch for the JUnit Tests. https://git.eclipse.org/r/#/c/15130/ Instead of changing the existing tests, I've added new generic versions of the classes. The reason for this was that: 1. I think it's good to have tests for the backwards compatibility to the non-generic use of the viewers 2. The class TestModelContentProvider implements the generified IStructuredContentProvider and the currently not generified ITreeContentProvider. The ITreeContentProvider also implements the IStructuredContentProvider. So the ContentProvider had to implent a typed and a none typed version of the IStructuredContentProvider interface, which is not possible.
(In reply to comment #9) > I've uploaded a patch for the JUnit Tests. > https://git.eclipse.org/r/#/c/15130/ Abandoned, I guess we need a new review URL PW
Yes, I guess an update for the existing testcases is a better solution. But for this update wee need to update the TreeViewer first.
Hi all, I'm working with this issue in a separated repository [1]. Considering that ComboViewer [2], Snippet063ComboViewer [3], and ComboViewerTest [3] are generified, I think that this issue should be marked as resolved. [1] - https://github.com/jeandersonbc/eclipse.platform.ui [2] - https://github.com/jeandersonbc/eclipse.platform.ui/blob/master/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/ComboViewer.java [3] - https://github.com/jeandersonbc/eclipse.platform.ui/blob/master/examples/org.eclipse.jface.snippets/Eclipse%20JFace%20Snippets/org/eclipse/jface/snippets/viewers/Snippet063ComboViewer.java [4] - https://github.com/jeandersonbc/eclipse.platform.ui/blob/master/tests/org.eclipse.ui.tests/Eclipse%20JFace%20Tests/org/eclipse/jface/tests/viewers/ComboViewerTest.java
I suggest to close this issue once we merged your work into master.
(In reply to Lars Vogel from comment #13) > I suggest to close this issue once we merged your work into master. I was suggesting to use a status more meaningful (maybe resolved?). Even better: I think I could just use Github Issue Tracker to keep issues/bugs organized (what was done, etc). In this case, ignore my last comment :)
This will be handled via Bug 402445 *** This bug has been marked as a duplicate of bug 402445 ***
