Bug 411577 - [Contributions] Customize Perspective has hiding conflicts for toolbars and menus
Summary: [Contributions] Customize Perspective has hiding conflicts for toolbars and m...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.4 M3   Edit
Assignee: Paul Webster CLA
QA Contact: Paul Webster CLA
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks: 418022 420956
  Show dependency tree
 
Reported: 2013-06-25 06:08 EDT by Jens Kuebler CLA
Modified: 2013-11-04 17:48 EST (History)
1 user (show)

See Also:

Attachments
Add prefix check (1.05 KB, text/plain)
2013-06-25 06:08 EDT, Jens Kuebler CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jens Kuebler CLA 2013-06-25 06:08:13 EDT 
Created attachment 232723 [details]
Add prefix check

If a toolbar and a menu has the same id and both elements shell be hidden updateHiddenElements does not consider the prefix in its containment check. 
The outcome is that only one of the item (either a toolbar item or a menu item) may be hidden at a time.

The fix is trivial in adding the prefix to the contains check. Then both items may be hidden at a time.

Reproduction can be done by hiding the file menu and toolbar items
Comment 1 Jens Kuebler CLA 2013-08-28 11:44:43 EDT 
Is there any way to get this into 4.3.1 as the change is really trivial ?
Comment 2 Paul Webster CLA 2013-09-10 15:08:38 EDT 
Jens, could you please sign your CLA?

PW
Comment 3 Jens Kuebler CLA 2013-09-25 03:49:02 EDT 
Done.
Comment 5 Paul Webster CLA 2013-10-29 10:01:13 EDT 
In 4.4.0.I20131028-2000

PW