Bug 411548 - NPE when no version present
Summary: NPE when no version present
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: 2.0.1   Edit
Assignee: Miles Parker CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-24 19:31 EDT by Miles Parker CLA
Modified: 2013-06-26 12:49 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Miles Parker CLA 2013-06-24 19:31:41 EDT 
When we can't get a file version for whatever reason, an NPE occurs. Looks like a simple matter of having a null check in the wrong place.

	at org.eclipse.equinox.launcher.Main.main(Main.java:1414)
Caused by: java.lang.NullPointerException
	at org.eclipse.mylyn.internal.gerrit.core.remote.PatchSetContentRemoteFactory.addComments(PatchSetContentRemoteFactory.java:87)
	at org.eclipse.mylyn.internal.gerrit.core.remote.PatchSetContentRemoteFactory.updateModel(PatchSetContentRemoteFactory.java:205)
	at org.eclipse.mylyn.internal.gerrit.core.remote.PatchSetContentRemoteFactory.updateModel(PatchSetContentRemoteFactory.java:1)
	at org.eclipse.mylyn.reviews.core.spi.remote.emf.RemoteEmfConsumer.applyModel(RemoteEmfConsumer.java:234)
	at org.eclipse.mylyn.reviews.core.spi.remote.JobRemoteService$2$1.run(JobRemoteService.java:77)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
	... 23 more
Comment 1 Miles Parker CLA 2013-06-24 19:33:42 EDT 
https://git.eclipse.org/r/14036
Comment 2 Miles Parker CLA 2013-06-26 12:49:23 EDT 
Merged https://git.eclipse.org/r/14036