Bug 410934 - [regression] Draft review cannot be opened, synchronization failed
Summary: [regression] Draft review cannot be opened, synchronization failed
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 2.0   Edit
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: 2.0.1   Edit
Assignee: Miles Parker CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-17 11:46 EDT by Marc-André Laperle CLA
Modified: 2013-06-19 14:22 EDT (History)
2 users (show)

See Also:


Attachments
Error log (39.34 KB, text/plain)
2013-06-17 11:46 EDT, Marc-André Laperle CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marc-André Laperle CLA 2013-06-17 11:46:37 EDT
Created attachment 232448 [details]
Error log

Mylyn Reviews Connector: Gerrit 2.0.0.I20130617-0418

1. Create a query using Eclipse.org Reviews as repository.
2. Query Type: Open changes by project: linuxtools/org.eclipse.linuxtools
3. After it synchronizes, try to open task 13849: lttng: Add tracing RCP [I1a1cd9cf]
4. Task is empty. Clicking on the hyperlink "Synchronize to retrieve task data" doesn't do anything.

The error log also contains several exceptions, see attached log.
Comment 1 Marc-André Laperle CLA 2013-06-17 11:50:57 EDT
Link to gerrit for problematic review:
https://git.eclipse.org/r/#/c/13849/

This one also doesn't work:
https://git.eclipse.org/r/#/c/13780/
Comment 2 Miles Parker CLA 2013-06-17 13:15:51 EDT
Hi Marc-Andre,

I'm not sure this one is actually a Mylyn Reviews issue actually. I can't reach those tasks through the Web UI! I get "Application Error", while other linux tools tasks open just fine.

Also, note that the first error in the error log is from the Mylyn tasks framework.

So not sure what is going on here. I think perhaps we should check w/ Eclipse Webmaster to see if there is something broken with these particular tasks..?

cheers,

Miles
Comment 3 Marc-André Laperle CLA 2013-06-17 13:48:16 EDT
(In reply to comment #2)
> I'm not sure this one is actually a Mylyn Reviews issue actually. I can't
> reach those tasks through the Web UI! I get "Application Error", while other
> linux tools tasks open just fine.

I had a similar error a few minutes ago but it seems to work now. Can you try again?
Comment 4 Miles Parker CLA 2013-06-17 15:06:40 EDT
(In reply to comment #3)
> (In reply to comment #2)
> I had a similar error a few minutes ago but it seems to work now. Can you try
> again?

Sorry, just tried and it failed in the same way. :(

When it is working for you, I assume you still can't sync even when you force it either through the task list or the editor. (Perhaps try the Task Editor first.)

Do you see anything unusual about these particular reviews?
Comment 5 Miles Parker CLA 2013-06-17 15:17:32 EDT
I see that you added me to the review. Doing so allows me to open the review in web ui and indeed I can reproduce the issue now. Thanks! Escalating.
Comment 6 Marc-André Laperle CLA 2013-06-17 15:21:11 EDT
(In reply to comment #4)
> When it is working for you, I assume you still can't sync even when you
> force it either through the task list or the editor. (Perhaps try the Task
> Editor first.)

I tried both. Task list first, then editor. Then I tried editor first then task list.

> Do you see anything unusual about these particular reviews?

No yet, just that they are drafts.
Comment 7 Miles Parker CLA 2013-06-17 15:55:03 EDT
https://git.eclipse.org/r/13857

Unfortunately, it seems that the Gerrit JSON RPC calls don't appear to populate with empty lists. For drafts there isn't any approval information. We should also be checking for draft types, but it isn't clear what versions of the Gerrit API this is supported under, so that warrants a closer look. In any case, the change above should fix the immediate issue.
Comment 8 Miles Parker CLA 2013-06-19 14:22:08 EDT
.