Community
Participate
Working Groups
Hi everyone, as the Intent project is under the Mylyn Docs component, I defined the Intent User Guide and Preference Page under the Mylyn categories. However, these information are defined "too low" in the plugin hierarchy according to me: although Intent has no code dependency toward Mylyn Tasks, I have to import: - the org.eclipse.mylyn.task.ui plugin (that declares the 'org.eclipse.mylyn.preferencePages.Mylyn' Mylyn Preference Page) - the org.eclipse.mylyn.help.ui plugin (that declares the org.eclipse.mylyn.help.ui/primary-toc.xml#additions entry in the Eclipse help). This may seem to be a detail, but this introduces a dependency from Intent to those 2 plugins, and I have to use the "org.eclipse.mylyn.ide_feature.feature.group" feature to build Intent, although 80% of Intent should not depend and eclipse.ide or core.resource. Could it be possible to pull up the Mylyn Preference Category & the default Mylyn help in some mylyn.commons plugins without too much dependency? Please let me know if I'm not making cense or if you have a good reason to do so. Best regard, Alex
Sounds reasonable to me, guys?
The preference node used to be called 'Tasks' but we now seem to have settled on Mylyn. It makes sense to me to pull it up but we would probably need to introduce a new feature for others to consume it.
Yep a new feature providing both the Preference Page category & the general help topic would be great ! Thanks a lot for your fast answer, Alex
Makes sense to me. Alex, are you interested in submitting a review with the proposed change?
Of course, but I fear I don't know Mylyn good practices and sub-projects enough to make a good contribution without help :) But if we decide together: - if we should have only one plugin holding both Preference Page & doc entries or 2 (one for each) - basically this plugin would have the fewest dependencies possible so that contributing plugins do not have to rely on some mylyn UI plugin - the name & location in git repository of this (these) plugin(s) then I should be able to do it :) In regards to builds, I'm only experienced with tycho, hope this is what you are using. Thanks again, Alex
Let's consider this for 3.10.
I'm afraid we probably won't be able to spend any time on this in the 3.10 release cycle since it will be a significant restructuring. I think what we want here is: * an o.e.m.commons.preferences plugin declaring the preference page * an o.e.m.commons.help.ui plugin declaring the help * an o.e.m.commons.integrations feature including both of the above plugins Steffen, does that make sense to you?
Hi Sam, yes this is exactly what I had in mind.
Hi everyone, any news on this subject ? Best regards, Alex
This won't make it for 3.10 but we'll consider it for 3.11. It would be great if you took a look at how the existing projects are structured and submitted a review.
Sure! Right now I'm in eclipse-con rush on Intent, but just after the conference I should have time to submit a review.
That's great to hear!
Hey guys! Just to let you know I'll start working on this next week, seems not too long. Is the following still OK (quoting Sam previous message)? * an o.e.m.commons.preferences plugin declaring the preference page * an o.e.m.commons.help plugin declaring the help * an o.e.m.commons.integrations feature including both of the above plugins Best regards, Alex
(In reply to comment #13) > Is the following still OK (quoting Sam previous message)? > * an o.e.m.commons.preferences plugin declaring the preference page > * an o.e.m.commons.help plugin declaring the help > * an o.e.m.commons.integrations feature including both of the above plugins Since that would be a separate component I would suggest to use a separate namespace as we have done for other components, i.e.: * o.e.m.commons.preferences.ui plugin declaring the preference page * o.e.m.commons.preferences.help plugin declaring the help * o.e.m.commons.preferenes-feature (feature ID being o.e.m.commons.preferenes) feature including both of the above plugins
Maybe I misunderstood, but I thought the help plugin would be to declare the top level help entry and neither it nor the feature were related to preferences.
(In reply to comment #15) > Maybe I misunderstood, but I thought the help plugin would be to declare the top > level help entry and neither it nor the feature were related to preferences. Right. Then the component should be IDE? • o.e.m.commons.ide.ui plugin declaring the preference page • o.e.m.commons.ide-feature Any reason we need a separate bundle for help and preference page?
No, I guess not. o.e.m.commons.ide.ui could have the preference page and the help.
Hi Alex, are you still planning to work on this? We're planning to do the RC build on Feb. 18.
I'm moving this to the backlog as it's getting late in the release cycle. We can still consider pulling it back on.
