Bug 410754 - [regression] inline comments are not shown when clicking compare with base
Summary: [regression] inline comments are not shown when clicking compare with base
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 blocker with 1 vote (vote)
Target Milestone: 2.0.1   Edit
Assignee: Miles Parker CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-13 13:35 EDT by Sam Davis CLA
Modified: 2013-06-19 08:56 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Davis CLA 2013-06-13 13:35:11 EDT 
Inline comments are not shown when clicking compare with base. I see them when opening files from the patch set section. Restarting and deleting the .reviews file did not fix the problem. I am not seeing them for any review.
Comment 1 Miles Parker CLA 2013-06-13 13:46:27 EDT 
But they are shown when clicking compare to other patch sets?
Comment 2 Sam Davis CLA 2013-06-13 14:26:21 EDT 
No.
Comment 3 Steffen Pingel CLA 2013-06-13 16:53:14 EDT 
That sounds like it could be the same problem as bug 410580.
Comment 4 Sam Davis CLA 2013-06-13 17:40:57 EDT 
I am getting that error sometimes too, but I am not seeing inline comments on any review, even when I don't get that error. I thought this was working yesterday but I guess not.
Comment 5 Miles Parker CLA 2013-06-13 21:01:24 EDT 
https://git.eclipse.org/r/#/c/13811/

I was a little concerned that this might create a regression off fix for bug 410486, but I couldn't reproduce that one so I think it's ok.
Comment 6 Sam Davis CLA 2013-06-14 13:32:37 EDT 
So that fix caused this bug? I guess we should have tested it better...
Comment 7 Miles Parker CLA 2013-06-14 14:02:13 EDT 
(In reply to comment #6)
> So that fix caused this bug? I guess we should have tested it better...

Yeah, that was pretty quick and dirty as the NPE was a real blocker and the code is quite complex. But a better question is why the unit tests didn't catch this. I think it's because this is being triggerred from UI code -- we don't have the "pull" side pushed to core in the same way that we have moved all of the "pull" side to core with this release.
Comment 8 Miles Parker CLA 2013-06-14 18:21:42 EDT 
Merged https://git.eclipse.org/r/#/c/13811/

Sam, please reopen if this doesn't solve it.