Bug 410520 - [regression] invalid XML character error when syncing a review with gif files
Summary: [regression] invalid XML character error when syncing a review with gif files
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P2 major (vote)
Target Milestone: 2.0.1   Edit
Assignee: Miles Parker CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 409427
Blocks:
  Show dependency tree
 
Reported: 2013-06-11 14:13 EDT by Sam Davis CLA
Modified: 2013-07-13 06:45 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Davis CLA 2013-06-11 14:13:32 EDT 
Some time after opening a review with gif files, I got this error:

org.eclipse.swt.SWTException: Failed to execute runnable (java.lang.RuntimeException: An invalid XML character (Unicode: 0x10) was found in the element content:GIF89a

Now whenever I sync that review, I get:

Synchronization failed

java.lang.RuntimeException: An invalid XML character (Unicode: 0x10) was found in the element content:GIF89a


I don't get it for all reviews with gifs, only one.
Comment 1 Steffen Pingel CLA 2013-06-11 17:36:26 EDT 
Miles, is actual file content persisted to EMF XML files or is this something else?
Comment 2 Miles Parker CLA 2013-06-12 15:00:13 EDT 
I can reproduce with just that task. (Unfortunately, it's on our internal task system, so I can't post it here.) Probably random unlucky byte, < 0x32 are really problematic w/ encoding.

(In reply to comment #1)
> Miles, is actual file content persisted to EMF XML files or is this something
> else?

It's the actual content. This is one of the reasons that I want to go to Binary btw. All of this mostly text data will get seriously compressed, and we should be able to avoid all of these weird ML encoding issues -- plus it's totally platform neutral. So I think bug 409427 will fix it. I'm going to try to work on that this week.
Comment 3 Miles Parker CLA 2013-06-12 19:27:38 EDT 
As predicted, https://git.eclipse.org/r/#/c/13782/ fixes it. :)
Comment 4 Miles Parker CLA 2013-06-17 19:13:23 EDT 
 https://git.eclipse.org/r/#/c/13782 Should fix.