Bug 409935 - On Publish Comments dialog "Publishes 0 draft" should be "... 0 drafts" or "no drafts"
Summary: On Publish Comments dialog "Publishes 0 draft" should be "... 0 drafts" or "n...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 7
: P3 trivial (vote)
Target Milestone: 2.0.1   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard: sprint=2;effort=1;
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-05 05:20 EDT by Tomasz Zarna CLA
Modified: 2013-06-17 04:11 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2013-06-05 05:20:35 EDT 
I'm not a native speaker so correct me if I'm wrong, but the message on Publish Dialog says "Publishes 0 draft" if there are no inline comments to be published. Shouldn't it say "... 0 drafts" or "... no drafts"?
Comment 1 Tomasz Zarna CLA 2013-06-05 05:23:21 EDT 
A quick patch: https://git.eclipse.org/r/#/c/13579/
Comment 2 Steffen Pingel CLA 2013-06-05 06:25:25 EDT 
The message in the dialog could just be hidden if there are no drafts.
Comment 3 Miles Parker CLA 2013-06-13 13:54:18 EDT 
> The message in the dialog could just be hidden if there are no drafts.

+1, looks like he's got that in latest. What would be a lot better would be to have some kind of scrollable list of comments with edit capabilites, but that's obivously out of scope for this bug.

(Tomek, please feel free to add me as reviewer for any of these -- I didn't notice you had this one out there.)
Comment 4 Miles Parker CLA 2013-06-13 19:14:22 EDT 
https://git.eclipse.org/r/#/c/13579/ Merged. Thanks again, Tomek.