Bug 408785 - Allow builder arguments for clean builds in InternalBuilder implementations
Summary: Allow builder arguments for clean builds in InternalBuilder implementations
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 4.2.2   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-Resources-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-23 04:10 EDT by Johann Draschwandtner CLA
Modified: 2015-03-25 11:25 EDT (History)
1 user (show)

See Also:


Attachments
Proposed patch for R3_8_mainanance (5.75 KB, patch)
2013-05-23 04:10 EDT, Johann Draschwandtner CLA
no flags Details | Diff
Proposed patch for master (5.21 KB, patch)
2013-05-23 04:15 EDT, Johann Draschwandtner CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Johann Draschwandtner CLA 2013-05-23 04:10:46 EDT
Created attachment 231349 [details]
Proposed patch for R3_8_mainanance

InternalBuilder defines methods:
protected abstract IProject[] build(int kind, Map<String, String> args, IProgressMonitor monitor) throws CoreException;
protected abstract void clean(IProgressMonitor monitor) throws CoreException;

I'm writing a Builder based on that API, but would like to make use of the
argument map for the clean step too, as the builder is based on an external tool (make in this case) it would make sense to extend the api.

The class BuildManager drops the arguments if the trigger type of the build was
CLEAN_BUILD.
Comment 1 Johann Draschwandtner CLA 2013-05-23 04:15:40 EDT
Created attachment 231351 [details]
Proposed patch for master
Comment 2 Szymon Ptaszkiewicz CLA 2014-04-29 05:40:19 EDT
Too late for API changes in 4.4. Moving to 4.5.
Comment 3 Szymon Ptaszkiewicz CLA 2015-03-25 11:25:45 EDT
Not planned for 4.5.