Bug 408640 - Update Gerrit to 2.6.1
Summary: Update Gerrit to 2.6.1
Status: RESOLVED FIXED
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: Gerrit (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Eclipse Webmaster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 408489 408490
Blocks: 401239
  Show dependency tree
 
Reported: 2013-05-21 17:42 EDT by Thanh Ha CLA
Modified: 2013-06-24 15:15 EDT (History)
12 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thanh Ha CLA 2013-05-21 17:42:46 EDT
Per discussion in Bug 408489 we should update Gerrit to 2.6.0 along with the new CLA service we are implementing.
Comment 1 Denis Roy CLA 2013-05-24 15:39:07 EDT
42x improvement on git clone and git fetch

Running gerrit gc allows JGit to optimize a repository to serve clone and fetch faster than C Git can, with massively lower server CPU required. Typically Gerrit 2.6 can completely transfer a project to a client faster than C Git can finish "Counting" the objects.

http://gerrit-documentation.googlecode.com/svn/ReleaseNotes/ReleaseNotes-2.6.html



Kind of ironic too that "svn" is part of that URL  ;)
Comment 3 Thanh Ha CLA 2013-05-31 10:23:54 EDT
I did a test upgrade in a local sandbox on my laptop from 2.5.2 to 2.6 by using a dump of the LTS database. Did a quick check of the usually functionality such as cloning, pushing, pushing for review, reviewing code, etc... didn't notice any obvious issues.

A note for my own interest, it seems Gerrit upgrade walks through upgrading incrementally each version of the Gerrit schema.

Upgrading database schema from version 73 to 74 ...
Upgrading database schema from version 74 to 75 ...
Upgrading database schema from version 75 to 76 ...
Upgrading database schema from version 76 to 77 ...
Comment 4 Markus Kuppe CLA 2013-06-04 10:56:37 EDT
Any chance you can update to 2.7 directly? The Rest API has seen some additional love, e.g. a get patch call [1].

Thanks
Markus

[1] https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#get-patch
Comment 5 Thanh Ha CLA 2013-06-04 21:41:48 EDT
Looks like Gerrit 2.7 is also a RC release. I don't see why we couldn't skip to this version as long as our CLA plugin still works with it, unless anyone else has a reason why we shouldn't.

I'll look into putting 2.7 on our sandbox and testing a 2.5 upgrade to 2.7; also making sure our CLA plugin still works in this release.
Comment 6 Denis Roy CLA 2013-06-04 22:11:59 EDT
> Looks like Gerrit 2.7 is also a RC release.

Seems odd to have 2 releases at the same time. I'll pull the changelogs tomorrow to see what's in 2.7 vs. 2.6.  I just want to make sure they don't do like kernel.org where odd-numbered releases are dev releases.
Comment 7 Denis Roy CLA 2013-06-04 22:16:18 EDT
2.6 is likely being released as we speak, since the Release Notes have a download link for it, but right now I get a 404

http://gerrit-documentation.googlecode.com/svn/ReleaseNotes/ReleaseNotes-2.6.html

That means 2.7 is likely a few weeks away.
Comment 8 Thanh Ha CLA 2013-06-05 15:56:48 EDT
Did an update from 2.5.2 to 2.7 and looks like 2.7rc1 adds 2 new schema versions 78 and 79. Looks like there were changes to drop 4 tables as well in the latest schema.

Still need to test that our gerrit cla plugin still works.


Upgrading database schema from version 73 to 74 ...
Upgrading database schema from version 74 to 75 ...
Upgrading database schema from version 75 to 76 ...
Upgrading database schema from version 76 to 77 ...
Migrated label types from database to All-Projects project.config
Upgrading database schema from version 77 to 78 ...
Upgrading database schema from version 78 to 79 ...
Execute the following SQL to drop unused objects:

  DROP TABLE approval_categories;
  DROP TABLE approval_category_values;
  DROP TABLE account_group_includes_audit;
  DROP TABLE account_group_includes;
  ALTER TABLE changes DROP COLUMN nbr_patch_sets;
Comment 9 Thanh Ha CLA 2013-06-05 16:21:25 EDT
(In reply to comment #8)
> Still need to test that our gerrit cla plugin still works.

I ran a few quick tests with our Gerrit CLA Plugin and it appears to work as expected in 2.7.
Comment 10 Denis Roy CLA 2013-06-10 11:25:41 EDT
Plan is to upgrade to whichever release is available the week of 6/17 (Kepler Quiet Week).
Comment 11 Steffen Pingel CLA 2013-06-10 14:41:17 EDT
Thanks for the heads up. Unfortunately the Mylyn connector does not yet support 2.6/2.7 RCs (due to the REST API changes: bug 395059). Would it be possible to just upgrade to 2.5.4 for now?

In any case, I certainly don't want to hold up the CLA change which is way awesome. We should eventually have support for 2.6 but it'll be a bit of work to consume the new remote API and changed data model.
Comment 12 Thanh Ha CLA 2013-06-10 14:46:20 EDT
(In reply to comment #11)
> Thanks for the heads up. Unfortunately the Mylyn connector does not yet
> support 2.6/2.7 RCs (due to the REST API changes: bug 395059). Would it be
> possible to just upgrade to 2.5.4 for now?

Unfortunately the CLA plugin we have requires Gerrit 2.6 at least.
Comment 13 Matthias Sohn CLA 2013-06-10 16:08:32 EDT
(In reply to comment #7)
> 2.6 is likely being released as we speak, since the Release Notes have a
> download link for it, but right now I get a 404
> 
> http://gerrit-documentation.googlecode.com/svn/ReleaseNotes/ReleaseNotes-2.6.
> html

2.6 has no more blocking bugs, see
https://groups.google.com/forum/?fromgroups#!topic/repo-discuss/zgLO6avxBkE
so it should be ready soon.
Comment 14 Matthias Sohn CLA 2013-06-10 16:10:21 EDT
Shawn just published 2.6 RC4 which will probably become 2.6 final
https://groups.google.com/forum/?fromgroups#!topic/repo-discuss/eDFAI-hylgI
Comment 15 Denis Roy CLA 2013-06-14 10:09:21 EDT
Matthias, do you have any news on 2.6 GA?
Comment 16 Matthias Sohn CLA 2013-06-17 07:41:02 EDT
(In reply to comment #15)
> Matthias, do you have any news on 2.6 GA?

latest ETA I saw from Shawn said he's probably releasing it today :-)
https://groups.google.com/d/msg/repo-discuss/RjhLtZYAqlg/WM9s1nBQRsYJ
Comment 17 Denis Roy CLA 2013-06-19 11:35:44 EDT
Ick, I'm still not seeing 2.6.0 ... *sweating*
Comment 18 Matthias Sohn CLA 2013-06-21 20:10:23 EDT
(In reply to comment #17)
> Ick, I'm still not seeing 2.6.0 ... *sweating*

Shawn just released Gerrit 2.6
https://groups.google.com/d/msg/repo-discuss/_lO2HRErDdQ/4D98jEwt2t0J
Comment 19 Matthias Sohn CLA 2013-06-24 05:27:17 EDT
one day later 2.6.1 was released [1] which fixes a security problem [2]

[1] http://gerrit-releases.storage.googleapis.com/gerrit-2.6.1.war
[2] http://gerrit-documentation.googlecode.com/svn/ReleaseNotes/ReleaseNotes-2.6.1.html
Comment 20 Thanh Ha CLA 2013-06-24 10:45:04 EDT
I tested an upgrade path for 2.6.1 with a snapshot of the git.eclipse.org database and a few random repos from the server. Upgrade went fine and no issues as far as I could tell. I was able to git clone from both the https and ssh URLs and tested pushing new branches and commits successfully via both URL types. I also confirmed that our Gerrit CLA plugin still works with this release.
Comment 21 Denis Roy CLA 2013-06-24 10:53:32 EDT
Great, let's schedule this for 3:00pm today.
Comment 22 Thanh Ha CLA 2013-06-24 10:56:58 EDT
(In reply to comment #21)
> Great, let's schedule this for 3:00pm today.

Ok I will do the update for LTS (bug 408489) and LocationTech (bug 408490) as well.
Comment 23 Thanh Ha CLA 2013-06-24 15:15:14 EDT
Update completed.