Bug 408198 - Key bindings not working for scrapbbok jpage in Java EE perspective
Summary: Key bindings not working for scrapbbok jpage in Java EE perspective
Status: RESOLVED INVALID
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 3.7.2   Edit
Hardware: PC Windows 7
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2013-05-16 02:33 EDT by Robert Nyholm CLA
Modified: 2017-11-03 12:21 EDT (History)
2 users (show)

See Also:


Attachments
Log file (965.06 KB, text/plain)
2013-05-17 01:18 EDT, Robert Nyholm CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Nyholm CLA 2013-05-16 02:33:30 EDT
If I edit a scrapbook.jpage in the Java EE perspective the keybindings Ctrl+Shift+D, Ctrl+Shift+I and Ctrl+U no longer works. However if I select the expression, right-click on it and select Display, Inspect or Execute then it works.
If I switch perspective to Java then the key bindings works as they should.
Comment 1 Paul Webster CLA 2013-05-16 06:45:55 EDT
Are you in Indigo?  Or Juno?

Please attach anything in your .log file, <workspace>/.metadata/.log

PW
Comment 2 Robert Nyholm CLA 2013-05-16 07:34:54 EDT
(In reply to comment #1)
> Are you in Indigo?  Or Juno?
> 
> Please attach anything in your .log file, <workspace>/.metadata/.log
> 
> PW

I'm using Indigo.

This error doesn't produce any entry in my .log file, so I don't think there is any need for attaching it.
When I for example mark and press Ctrl+U for following expression in scrapbook.jpage

String s = "test";
System.out.println("s = " + s);

nothing happens, no error, nothing at all. But if I right click on the expression and select Execute from there then it works, as intended.
Described scenario occurres in the Java EE perspective.

On the other hand, if switch perspective to the Java view then the key binding works as they should.

So it seems to be a small bug somewhere.
Comment 3 Paul Webster CLA 2013-05-16 08:09:20 EDT
(In reply to comment #2)
> 
> This error doesn't produce any entry in my .log file, so I don't think there
> is any need for attaching it.

So there are no errors in your error log?

(In reply to comment #0)
> If I edit a scrapbook.jpage in the Java EE perspective the keybindings
> Ctrl+Shift+D, Ctrl+Shift+I and Ctrl+U no longer works.

When did they work in the Java EE perspective, that they no longer work now?

PW
Comment 4 Robert Nyholm CLA 2013-05-16 09:02:21 EDT
> (In reply to comment #2)
> > 
> > This error doesn't produce any entry in my .log file, so I don't think there
> > is any need for attaching it.
> 
> So there are no errors in your error log?

No errors related to this bug exists in the log.
> 
> (In reply to comment #0)
> > If I edit a scrapbook.jpage in the Java EE perspective the keybindings
> > Ctrl+Shift+D, Ctrl+Shift+I and Ctrl+U no longer works.
> 
> When did they work in the Java EE perspective, that they no longer work now?

They never worked in Java EE perspective, the key bindings only works in Java perspective.
> 
> PW
Comment 5 Paul Webster CLA 2013-05-16 09:11:38 EDT
(In reply to comment #4)
> 
> No errors related to this bug exists in the log.

If there are any errors, please attach them.

> They never worked in Java EE perspective, the key bindings only works in
> Java perspective.

This is most like related to keybindings backed by actionSets.  If the actionSet is active in the Java perspective but not in the java EE perspective, then the keybinding won't work.

Can you see a Command Group in CustomizePerspective>Command Groups that shows the 3 actions you mentioned?

PW
Comment 6 Robert Nyholm CLA 2013-05-17 01:18:13 EDT
Created attachment 231128 [details]
Log file
Comment 7 Robert Nyholm CLA 2013-05-17 01:19:17 EDT
(In reply to comment #5)
> (In reply to comment #4)
> > 
> > No errors related to this bug exists in the log.
> 
> If there are any errors, please attach them.

I attached the log file now.
> 
> > They never worked in Java EE perspective, the key bindings only works in
> > Java perspective.
> 
> This is most like related to keybindings backed by actionSets.  If the
> actionSet is active in the Java perspective but not in the java EE
> perspective, then the keybinding won't work.
> 
> Can you see a Command Group in CustomizePerspective>Command Groups that
> shows the 3 actions you mentioned?

Yes I can see the actions there.
> 
> PW
Comment 8 Paul Webster CLA 2013-05-17 05:06:12 EDT
(In reply to comment #7)
> > Can you see a Command Group in CustomizePerspective>Command Groups that
> > shows the 3 actions you mentioned?
> 
> Yes I can see the actions there.

If you open the Customize Perspective Dialog in the Java EE perspective is that command group selected?

PW
Comment 9 Robert Nyholm CLA 2013-05-20 01:40:55 EDT
(In reply to comment #8)
> (In reply to comment #7)
> > > Can you see a Command Group in CustomizePerspective>Command Groups that
> > > shows the 3 actions you mentioned?
> > 
> > Yes I can see the actions there.
> 
> If you open the Customize Perspective Dialog in the Java EE perspective is
> that command group selected?
> 
> PW

I feel kind of dumb right now...
You're correct, the command groups availability was indeed unselected. Directly after selecting that command groups availability the key binding works as they should.
So we can close this case.
Comment 10 Paul Webster CLA 2013-05-21 07:26:45 EDT
(I only knew that because it happened to me :-)  Thanks for pursuing this.

PW
Comment 11 Randy Hudson CLA 2017-11-03 12:21:49 EDT
When you open the context menu, the MOD1+U keybinding is displayed there regardless of whether the "Java debug" action set is enabled in the current perspective.  This is misleading, since the keybinding doesn't work at all.

There is no reason why the user should be forced to show the "Execute" action all the time.  The scrapbook editor should dynamically register the action, just like it does for "Quick Fix".