Description John Arthorne 2013-04-29 13:37:56 EDT

The test case IJobManagerTest.testJobFamilyWakeUp has a race condition that causes the test to fail incorrectly. Here is the current code:

if (family1[i].getState() == Job.RUNNING)
	runningCount++;
else
	assertState("7.1." + i, family1[i], Job.WAITING);

The intent is to verify that the job is either waiting or running. However, there are two calls to job.getState(). If the job is still waiting when getState() is called the first time, we enter the else block. At this point the job starts running, and the assertion fails because it expects waiting.  We can see from the failure message that this is what happened:

7.1.0: expected state: WAITING actual state: RUNNING 

It is perfectly valid that the job is running here, we just have a badly written test.