Bug 406284 - TrimStack does not use localized label for minimized Parts in TrimStack
Summary: TrimStack does not use localized label for minimized Parts in TrimStack
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.3 M7   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2013-04-23 03:54 EDT by Sebastian Weis CLA
Modified: 2013-05-22 09:51 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Weis CLA 2013-04-23 03:54:52 EDT
Version: Kepler Release Build id: 20130320-2352

When a Part(Stack) is minimized, the ToolTip set is not the localized value of the Part's label but the actual String (e.g. "%key" instead of "value").

I think this is caused in

org.eclipse.e4.ui.workbench.addons.minmax.TrimStack

updateTrimStackItems() {
...
newItem.setToolTipText(getLabelText(labelElement));
}

If in

getLabelText(MUILabel label)

getOverrideTitleToolTip((MUIElement) label)

returns null the Label is set to

String string = label.getLabel();

I think this should instead be

String string = label.getLocalizedLabel;
Comment 1 Eric Moffatt CLA 2013-04-24 11:11:16 EDT
Sebastian, good pickup, thanks !

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1f4db9d6fcb425dc2ab861b75fbdb78fb246d78f

Test this on your app once M7 goes out and let me know how it goes...
Comment 2 Sebastian Weis CLA 2013-04-29 10:05:03 EDT
Hello Eric, thanks for the quick fix. I will let you know if this solves the problem.
Comment 3 Eric Moffatt CLA 2013-05-02 13:38:36 EDT
Paul, this is almost certainly fixed (at least the code change to use 'getLocalizedLabel' is in, I haven't marked it verified since I'm not set up to test it...
Comment 4 Eric Moffatt CLA 2013-05-17 11:04:02 EDT
Verified (visually) in 4.3.0.I20130516-2200.

Sebastian, please test this on RC1 and comment whether it fixes your issue or not...
Comment 5 Sebastian Weis CLA 2013-05-22 09:51:57 EDT
Hello Eric, I checked with 4.3RC1-201305162200 and it now works as expected. Thanks again for the quick fix.