Bug 405647 - clicking on review file URL should open file editor
Summary: clicking on review file URL should open file editor
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 enhancement (vote)
Target Milestone: 2.7   Edit
Assignee: Chris Poon CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed, noteworthy
Depends on:
Blocks:
 
Reported: 2013-04-12 16:29 EDT by Miles Parker CLA
Modified: 2015-08-04 14:41 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Miles Parker CLA 2013-04-12 16:29:52 EDT 
Currently, if the user clicks on a link to a gerrit file, e.g. like https://git.eclipse.org/r/#/c/11012/15/org.eclipse.mylyn.gerrit.tests/src/org/eclipse/mylyn/internal/gerrit/core/remote/GerritRemoteFactoryTest.java, the review editor is opened. We should intercept that and load the actual file if it's available/retrievable.
Comment 1 Miles Parker CLA 2014-02-07 15:49:21 EST 
Sam, Leo, you might take a look at this one, would be a nice simple enhncement I think..
Comment 2 Sam Davis CLA 2014-02-07 16:54:40 EST 
Makes sense to open the compare editor. Marking P2 since it should be easy to do.
Comment 3 Sam Davis CLA 2015-05-20 13:52:01 EDT 
It turns out that it would be quite difficult to get this to work in the case that the user doesn't already have the patch set cached, because there doesn't seem to be a way for the GerritUrlHandler to listen for when the patch set is downloaded. But we can make it work when they do have the patch set cached, and if they don't, we can at least expand the section and start the download.
Comment 4 Sam Davis CLA 2015-05-20 17:27:19 EDT 
Fixed with https://git.eclipse.org/r/#/c/47940/. Thanks for the contribution!
Comment 5 Eclipse Genie CLA 2015-08-04 14:41:09 EDT 
New Gerrit change created: https://git.eclipse.org/r/53174