Community
Participate
Working Groups
This bug is mostly to document changes I'm making to "clean up" some of the production scripts. Its primarily motivated by noticing we are currently getting two copies of "basebuilder" (for the few times we need it). Once in {root}/org.eclipse.releng.basebuilder_tagname and again in {root}/sitedir/downloads/drops4/{buildId}/org.eclipse.releng.basebuilder The latter one was done so specifically so that what ever basebuilder we use during the build is the exact same one we use when processing the test results, which might not be available for several hours (days?). While one approach or the other would likely work, we definitely don't need two, and I prefer the "drop specific" (or "build specific") version. This will be more important when we move "off" the base builder, and just install a mini-eclipse, and add tools with p2, etc. Plus, back to the "clean up" topic, as I was preparing to make this change, noticed some functions with (currently) unused variables ... small clumps of commented out code, etc.
Commit to change basebuilder directory: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=0252b0bb078906c5e483adad082c6b2ab9cb0227 Commit to clean up (nesting) logic and variables in master-build.sh http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=6fe2820f750cbe8ccceeacb0cca7ad82a77c3eaa Commit to cleanup other unused variables, comments, and commented out code. http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=ca65906eb78a93e395c93f555b2efd3179dd24ab
With this last commit, I'm done with this for now. This once contains a little more cleanup, some renames, tried to standardize formatting of bash scripts, and ... off topic of this bug (more bug 400633 comment 10)... added a function to test the number of arguments passed to a function matched what was expected (for bullet-proofing). http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=5599fdcf2c85b71e5ccd2a44d0ff50f5861e8471
Follow up commit to make common 'basebuilder' eclipse executable. http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=f6f21dae6474544eab879f69f720b708f6a4bd22
mass change to 'verified', as these bugs are either routine or obviously fixed build breaks.
