Bug 404373 - Chevron not displayed on windows for CoolItem
Summary: Chevron not displayed on windows for CoolItem
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6.2   Edit
Hardware: PC Windows 8
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2013-03-26 10:34 EDT by Esteban DUGUEPEROUX CLA
Modified: 2020-04-22 05:54 EDT (History)
2 users (show)

See Also:


Attachments
Pure SWT Snippet showing CoolItem working on Windows (3.17 KB, application/octet-stream)
2013-03-26 10:34 EDT, Esteban DUGUEPEROUX CLA
no flags Details
SWT/JFace Snippet showing CoolItem not working on Windows (2.14 KB, application/octet-stream)
2013-03-26 10:36 EDT, Esteban DUGUEPEROUX CLA
no flags Details
A snippet code of CoolBarManager with dynamic changes of visible actions (3.18 KB, application/octet-stream)
2013-04-19 05:23 EDT, Esteban DUGUEPEROUX CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Esteban DUGUEPEROUX CLA 2013-03-26 10:34:56 EDT
Created attachment 229045 [details]
Pure SWT Snippet showing CoolItem working on Windows

I raise this bugzilla about a specific Windows issue, exists on Windows 8/7/XP, the chevron of the CoolItem is not displayed on windows. See http://www.eclipse.org/forums/index.php/t/462978/ for all details.

I have seen that even on Linux the chevron for the CoolItems of the main toolBar of Eclipse does not appears with Eclipse 4.3 M5a
Comment 1 Esteban DUGUEPEROUX CLA 2013-03-26 10:36:54 EDT
Created attachment 229046 [details]
SWT/JFace Snippet showing CoolItem not working on Windows

I have attached 2 code snipperts :
 - one in pure SWT code showing that a chevron is displayed to access hidden buttons on Windows
 - one in SWT + JFace ToolBarManager/CoolBarManager code showing that it does not works on Windows.
Comment 2 Esteban DUGUEPEROUX CLA 2013-04-18 05:26:34 EDT
On windows to fix the issue of not displayed chevron on Snippet140Bis.java example, I add the following lines after line 42 :

ToolBarContributionItem toolBarContributionItem = (ToolBarContributionItem) coolBarManager.getItems()[0];
toolBarContributionItem.setMinimumItemsToShow(1);

with that the ToolBarContributionItem will compute a width for the minimumSize lower than by default.

Now to have the chevron display on windows for the main coolBar of Eclipse we can add the following lines at the end of CoolBarManager.itemAdded() method :

if(item instanceof ToolBarContributionItem){
   ToolBarContributionItem toolBarContributionItem = ToolBarContributionItem)item;
   toolBarContributionItem.setMinimumItemsToShow(1);
}

But this remains a work-around. And there is yet a bug, for example on the main toolBar of Eclipse, on resize of the window the chevron appears/disappears if yes or not it remains enough place to display all actions, but on selection change when the set of actions to display changes the chevron disappears while it should be visible because there is actions not visible.

Could I have feedback of someone from jface or swt to help me in my analysis, especially of this last bug?

Best Regards.
Comment 3 Eric Moffatt CLA 2013-04-18 11:07:51 EDT
Can you identify a particular eclipse version that this works correctly in ?

Is it specific to a particular version of Windows (i.e. Does it work on XP but not Win 7...) ?
Comment 4 Esteban DUGUEPEROUX CLA 2013-04-18 11:57:08 EDT
This issue has been identied on Windows XP/7/8 and with Eclipse 3.6.2.
On my Windows 8, I have just tested with Eclipse 3.3 and the main toolbar does not show chevron.
Comment 5 Esteban DUGUEPEROUX CLA 2013-04-19 05:23:20 EDT
Created attachment 229899 [details]
A snippet code of CoolBarManager with dynamic changes of visible actions

I have attached a new release of the initial Snippet140.java to have a CoolBar managed by a CoolBarManager, whose visible actions changes when the user click on actions B8 or B9.

If at the beginning the user has decreased the width of the windows to have chevron displayed, now the user click on B8 action to have less visible actions and the chevron disappears, it's ok. Now the user click on B9 action to reset visible all actions which has the effect to display the chevron to show hidden actions. This jface/swt snippet show the correct behavior which should have also in the Eclipse main toolbar but it is not the case.
Comment 6 Eclipse Genie CLA 2020-04-22 05:54:41 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.