Bug 404095 - [Markdown] Add support for links and images
Summary: [Markdown] Add support for links and images
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.9.0   Edit
Assignee: Project Inbox CLA
QA Contact: David Green CLA
URL: http://daringfireball.net/projects/ma...
Whiteboard:
Keywords: contributed
Depends on: 329528
Blocks:
  Show dependency tree
 
Reported: 2013-03-21 18:35 EDT by Stefan Seelmann CLA
Modified: 2013-06-18 11:03 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Seelmann CLA 2013-03-21 18:35:49 EDT 
Add support for links in Markdown. This includes inline-style links, reference-style links, and automatic links. 

Also add support for images, both inline-style and reference-style images.

Validation rules would also be nice.

Follow up of 329528.
Comment 1 Stefan Seelmann CLA 2013-04-04 18:19:49 EDT 
Just wanted to add that this is almost ready, I hope I can submit a patch next weekend.
Comment 2 Stefan Seelmann CLA 2013-04-18 17:53:17 EDT 
This takes a bit longer, I found some more corner cases.
Comment 3 Stefan Seelmann CLA 2013-05-05 17:29:12 EDT 
Pushed a changeset to https://git.eclipse.org/r/#/c/12521/

Here is my contributor statement:
1. I have authored 100% of the content I'm contributing
2. I have the rights to donate the content to Eclipse
3. I contribute the content under the EPL
Comment 4 Steffen Pingel CLA 2013-05-07 08:01:34 EDT 
David, the contribution exceeds the 250 line limit so will need to go through a CQ. I'll tentatively put this on for the next milestone so we don't loose track of it.
Comment 5 David Green CLA 2013-05-08 11:09:20 EDT 
Thanks for spotting that Steffen.  We're not quite done on the review so does it make sense to wait on filling a CQ until we have a patchset that we're happy with?

@Stefan for future contributions if it make sense to have multiple smaller reviews that's fine - and it can make CQs unnecessary if the contribution size is smaller.
Comment 6 Steffen Pingel CLA 2013-05-08 12:27:11 EDT 
(In reply to comment #5)
> Thanks for spotting that Steffen.  We're not quite done on the review so does it
> make sense to wait on filling a CQ until we have a patchset that we're happy
> with?

Yes, that would make sense to me.
Comment 7 David Green CLA 2013-05-22 10:43:23 EDT 
filed CQ 7292
Comment 8 Tomasz Zarna CLA 2013-06-18 11:03:32 EDT 
This has been fixed in aea430d058cda2ad9d99ba4b05e91cb9b9c2f5a0