Bug 403235 - CommandContributionItem have to restore contributed tooltip when handler changes
Summary: CommandContributionItem have to restore contributed tooltip when handler changes
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.3 M7   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2013-03-13 12:54 EDT by Stephan Wahlbrink CLA
Modified: 2013-05-17 10:44 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Wahlbrink CLA 2013-03-13 12:54:10 EDT 
An IElementUpdater can set the tooltip of a CommandContributionItem. At moment the tooltip is not restored when the handler changes. It should be reset to the contributed tooltip like the label or icons.
Comment 1 Paul Webster CLA 2013-03-15 13:04:35 EDT 
http://wiki.eclipse.org/Platform_UI/How_to_Contribute

PW
Comment 2 Leonid Ripeynih CLA 2013-03-17 12:37:32 EDT 
Here is proposed fix
https://git.eclipse.org/r/11252
Comment 3 Stephan Wahlbrink CLA 2013-03-17 12:50:17 EDT 
I just created a patch too:

https://git.eclipse.org/r/#/c/11254/
Comment 4 Paul Webster CLA 2013-03-18 13:23:11 EDT 
Thanks Leonid and Stephan both for the fix.  I've merged it in as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=649adf35b5190b6c3dd8e2bde1b4b0ce0dc88853

PW
Comment 5 Paul Webster CLA 2013-05-17 10:44:52 EDT 
in 4.3.0.I20130516-2200

PW