Bug 403011 - [RenderingEngine] Full screen mode not remembered/restored on restart
Summary: [RenderingEngine] Full screen mode not remembered/restored on restart
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2.1   Edit
Hardware: Macintosh Mac OS X
: P3 minor with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2013-03-12 05:55 EDT by Manfredi Giordano CLA
Modified: 2020-03-19 10:20 EDT (History)
5 users (show)

See Also:


Attachments
Video demonstrating the issue (10.25 MB, video/quicktime)
2020-03-19 09:58 EDT, Brian Mauter CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Manfredi Giordano CLA 2013-03-12 05:55:17 EDT
If I quit from Eclipse while in full screen (OS X Lion feature), the next time I reopen Eclipse it doesn't load in full screen mode, it loads in window mode but the window is maximized.

-- Configuration Details --
Product: Eclipse 1.5.2.20130110-1126 (org.eclipse.epp.package.java.product)
Installed Features:
 org.eclipse.platform 4.2.1.v20130118-173121-9MF7GHYdG0B5kx4E_SkfZV-1mNjVATf67ZAb7
Comment 1 Brian de Alwis CLA 2013-10-22 10:08:27 EDT
I think we need to push the full-screen support into the MinMax support so that it's recorded into the model.
Comment 2 Eric Moffatt CLA 2014-02-12 09:41:19 EST
We remember the current state of the shell on shutdown by adding one of two tags;
"shellMaximized" or 'shellMinimized'. On rendering we check the tags and call the appropriate SWT Shell method.

When you say 'full screen mode' are you talking about something different ?
Comment 3 Manfredi Giordano CLA 2014-02-12 10:06:25 EST
I talk about the two little arrows on the top-right area of the window, the ones the let OS X apps go full screen with OS' APIs (as explained here https://developer.apple.com/library/mac/documentation/General/Conceptual/MOSXAppProgrammingGuide/FullScreenApp/FullScreenApp.html).
I'm honestly not using Eclipse from a while so I don't know if this issue is always there.
Comment 4 Brian de Alwis CLA 2014-02-12 10:23:22 EST
Eric -

OSX (and others) support a full-screen mode where a shell is resized to the full-screen with no trim.  This is typically done either through a keyboard command or by clicking on a special double-arrow item that appears in the shell toolbar.

   http://support.apple.com/kb/PH11359

I added full-screen support in 4.2 (bug 376394 and bug 378332).  I initially saved the state into the model as a tag "FullScreen", but had to back it out as we had no hooks for when the user triggered the OSX double-arrow tool item and so the state would get out of sync.

It looks like we should now be able get notification of user-initiated full-screen changes (bug 378332).  So we should be able to bring the model-based support back.
Comment 5 Eric Moffatt CLA 2014-02-13 15:18:41 EST
Interesting, I'd like to see how this compares to the 'full screen' mode that I'm currently implementing (see bug 427999 for details)...
Comment 6 Lothar Lattermann CLA 2016-09-30 09:17:37 EDT
We have the same issue. Our application works in full screen mode but the application doesn't remember this. As a workaround we manually set the mode for all windows stored in the application model.
Comment 7 Brian Mauter CLA 2020-03-19 09:58:49 EDT
Created attachment 282149 [details]
Video demonstrating the issue

Happy to convert this to another format if preferred...
Comment 8 Brian Mauter CLA 2020-03-19 10:20:00 EDT
Hi!  I've wanted this feature ever since we could make Eclipse go full screen.  It looked like there was movement on it a few years ago, which was encouraging at the time.

I don't think I'm the right person to code a fix for it, but I'm VERY WILLING to test.  I run Eclipse on several different Macs, and I have no problem reporting back with more video recordings, if needed.

Hopefully the attached video gives you some kind of idea of what Manfredi and I are seeing.  Other macOS apps that are closed while in fullscreen reopen back in fullscreen.  We'd just like Eclipse to do that too.

Thanks,
-Brian