Community
Participate
Working Groups
As a follow-on to bug 400997 comment 9, there are 2 more points I need to make on the "Navigating the user interface using the keyboard" help page, and then I think the doc will be complete: 1) Typing Enter when focus is on a page tab (i.e. editor or view tab) will move focus to the page tab's contents. (in SWT terms, if a CTabItem has focus, you can type Enter to move focus to the CTabItem's control). This is true whether you are in a view stack or an editor stack. 2) The sentence "Ctrl+PageUp and Ctrl+PageDown can be used for switching between the open editors" does not mention that Ctrl+PageUp and Ctrl+PageDown can be used for switching between views in a view stack.
This patch from bug 400997 comment 9 must be applied first: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=26eba63164ea8ac01e6a02e3f4908f698f1469f6
Dani, can you please review the words in this commit? http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=896bcf32d1e97096552199ffd4d4bd746ce98579 After bug 376011 was fixed, the old description of tab traversal did not match reality. So it is important to have the correct doc backported to 4.2.2+. You can test out the current behavior in any very recent build, since about the beginning of March. (I know that you can see it in I20130306-2330). Thanks!
"While on an editor's or view's tab, the left or right arrow keys select a different editor or view, and the Enter key navigates directly into the selected editor or view." I would rephrase this a bit: When the focus is on an editor or view tab, pressing the left/right arrow key moves to the previous/next tab and pressing Enter moves the focus to the current selection in the editor or view. "/" could also be replaced with "or".
Thanks - I like your words. Done, and kept the slashes: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=ce567c3435da1332266e3cb2bb03348efa7fd0b3
Backported the patch from comment 1: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?h=R4_2_maintenance&id=423202c8a1dd4016d5a7e266ea4f431666de480a Dani, can you please verify that I did the right thing on line 117 of org.eclipse.platform.doc.user/contexts_AntUI.xml? There was an href conflict: OLD: <topic label="Configuring accessibility options for textual editors" href="PLUGINS_ROOT/org.eclipse.platform.doc.user/concepts/accessibility/text_editor.htm"/> NEW: <topic label="Accessibility features in textual editors" href="concepts/accessibility/text_editor.htm"/> The old annotation was: Fixed bug 272167: [content assist] screen reader should read first proposal
Backported the patches from comment 2 and comment 4: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?h=R4_2_maintenance&id=857f9a6e72aa7814683eaa7b872dbcf6006d7412 http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?h=R4_2_maintenance&id=a2229a115519cb9be56e6730a93503d2a8c4770e Dani, this can be marked as fixed if you are happy with the patch in comment 5.
(In reply to comment #5) > Backported the patch from comment 1: > http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/ > ?h=R4_2_maintenance&id=423202c8a1dd4016d5a7e266ea4f431666de480a > > Dani, can you please verify that I did the right thing on line 117 of Looks good.
Also backported to 3.8.2+: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?h=R3_8_maintenance&id=171a1784d05fab44ee26623f5569788170ae0384 http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?h=R3_8_maintenance&id=a2be871890435a165ee4189ff046ff88dd6a72a6 http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?h=R3_8_maintenance&id=e0aa93f688a89c9200e8cd867860ed580cb2201a
I've update the bundle version in the manifest and the pom for both versions.
Thank-you, Dani.
