Community
Participate
Working Groups
I have a perspective extension like this: <perspectiveExtension targetID="org.eclipse.jdt.ui.JavaPerspective"> <hiddenToolBarItem id="org.eclipse.ui.navigate.next" /> <hiddenToolBarItem id="org.eclipse.ui.navigate.previous" /> <hiddenMenuItem id="org.eclipse.ui.run" /> </perspectiveExtension> In Eclipse 3.6.2, the annotation navigation toolbar buttons are hidden in the Java perspective but not in other perspectives. In Eclipse 4.2.2, the annotation navigation toolbar buttons are hidden in all perspectives. I have noticed that if I target the debug perspective instead of the java perspective, the toolbar buttons are never hidden, so I think it's just that they are not updating according to perspective changes. The hiddenMenuItem works correctly.
Very similar to bug 391481 PW
Just to confirm that build http://download.eclipse.org/eclipse/downloads/drops4/I20130409-0900/ does not fix this particular issue. As you say, the fix for bug 391481 might be a similar fix, but it's not "buy one get one free", sadly!
Created attachment 230952 [details] Application used during testing the fix I've added the application that I was using during working on the fix for the bug thanks, Daniel
Daniel / Paul, in order to the the extension to take effect I have to do a clean start...is this expected ? Other than that it works fine...
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4ab730aaad924f28aef63a3f4650c797be9fa0f6 Applied Daniel's fix...thanks !
(In reply to comment #5) > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=4ab730aaad924f28aef63a3f4650c797be9fa0f6 This fix will prevent hidden toolbar items from being modelled on startup (so they won't react to changes after the fact), and won't react to changes if they're made after the fact. I'd prefer we revert this commit and make sure we've got all the cases covered (target the save icon and the print icon to make sure they work). PW
Guys, I've uploaded the new patch to Gerrit that I believe addresses all concerns as well as fixes the memory leak introduced by previous patch :) http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=dacaf4ad01eff26cca72b5c0ca3b59aa7e73e8b8 However if it is still not good enough please revert the previous patch to fix the mentioned memory leak issue (when the CoolBarToTrimManager.fill method is executed it always creates the new model items and puts it to the MToolBar children list. The children items are present there until the particual perspective is opened) thanks in advance for review, Daniel
(In reply to comment #7) > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=dacaf4ad01eff26cca72b5c0ca3b59aa7e73e8b8 Thanks Daniel. I've reverted the original commit with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=3d6eeeb2857cc8b1bc5fb407e65ed250a892f28f as you re-examine https://git.eclipse.org/r/#/c/12819 you will have to include the elements of your original commit that you deem useful. PW
Released as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d2dcde53acc822bd07066824862836e568378896 PW
Verified in the build: I20131028-2000
Is it possible to back-port this to 4.3 (as part of 4.3 SR2)? Thanks, Christian
(In reply to Christian Georgi from comment #11) > Is it possible to back-port this to 4.3 (as part of 4.3 SR2)? No, our window for backporting things is over, we're at 4.3.2 RC3 PW
