Bug 402059 - [editor] Provide Copy URL menu item for Task comments
Summary: [editor] Provide Copy URL menu item for Task comments
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.9   Edit
Assignee: Frank Becker CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2013-02-28 15:23 EST by Miles Parker CLA
Modified: 2013-03-17 12:33 EDT (History)
2 users (show)

See Also:

Attachments
mylyn/context/zip (2.06 KB, application/octet-stream)
2013-03-16 10:37 EDT, Frank Becker CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Miles Parker CLA 2013-02-28 15:23:13 EST 
Currently, you can copy URL by right clicking on task editor header, and you can copy user name and id by clicking on "swish arrow" button next to comment. It would be nice to be able to copy the url for the specific comment from this button or by clicking on the comment header.
Comment 1 Frank Becker CLA 2013-03-12 17:04:09 EDT 
Here the review https://git.eclipse.org/r/#/c/11091/

Can someone review this?
Comment 2 Miles Parker CLA 2013-03-12 17:12:01 EDT 
I can't formally review because I'm not a tasks committer, but I'll give it a once over. I just tried it and works as expected for Bugzilla. (But see review on that point.)
Comment 3 Steffen Pingel CLA 2013-03-13 14:17:30 EDT 
(In reply to comment #2)
> I can't formally review because I'm not a tasks committer, but I'll give it a
> once over. 

Anyone can review any change. Please feel free to provide any input you have on the review. A tasks committer will have to provide a +2 vote though in order to merge the change.
Comment 4 Frank Becker CLA 2013-03-13 14:58:27 EDT 
create patch set 2 based on the comments from patch set 1
Comment 5 Miles Parker CLA 2013-03-15 14:26:13 EDT 
(In reply to comment #3)
> Anyone can review any change. Please feel free to provide any input you have on
> the review. A tasks committer will have to provide a +2 vote though in order to
> merge the change.

Does that mean that it would be appropriate for a non-committer to +1 or -1?
Comment 6 Sam Davis CLA 2013-03-15 15:56:04 EDT 
I would say yes. Part of being an open source project is that anyone can provide input.
Comment 7 Steffen Pingel CLA 2013-03-15 18:09:22 EDT 
(In reply to comment #5)
> Does that mean that it would be appropriate for a non-committer to +1 or -1?

Yes, it absolutely is. -1 may be perceived as a strong statement and should be well founded and inline with the project policies but generally speaking anyone should feel encouraged to provide feedback and participate in reviews.
Comment 8 Frank Becker CLA 2013-03-16 10:37:09 EDT 
The Gerrit review is now in HEAD.
Comment 9 Frank Becker CLA 2013-03-16 10:37:12 EDT 
Created attachment 228529 [details]
mylyn/context/zip
Comment 10 Steffen Pingel CLA 2013-03-17 12:33:22 EDT 
Thanks for implementing this, Frank. Please take a quick look at this follow up review: https://git.eclipse.org/r/11251.