Bug 401633 - Remove obvious performance bottlenecks
Summary: Remove obvious performance bottlenecks
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: All All
: P3 major with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on: 414853
Blocks:
  Show dependency tree
 
Reported: 2013-02-24 14:39 EST by Markus Keller CLA
Modified: 2015-05-13 09:46 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2013-02-24 14:39:17 EST 
Do a performance pass to remove obvious performance bottlenecks like bug 401632 in E4 and the compatibility layer.

Profile common scenarios like opening or switching editors, and measure where time is spent. Check the part listener and selection change events and ensure that events are only sent out once, that they are sent to the right parts, and that the order makes sense (should be the same as in 3.8).

Ensure that views are only laid out when the layout of the workbench window really changed, and that they are not redrawn unnecessarily.

One part of this work item is to create a view that registers for various workbench events and logs them. This will simplify regression testing against 3.8.
Comment 1 Lars Vogel CLA 2013-08-22 11:29:23 EDT 
Event tools was contributed to the the e4 tools by Daniel Rolka in 414853.
Comment 2 Markus Keller CLA 2014-04-30 10:54:05 EDT 
The pattern used in org.eclipse.e4.ui.css.swt.properties.css2.CSSPropertyFontSWTHandler.setFont(Widget, Font) is crazy: CSS code must not call

    control.setRedraw(false)
    ...
    control.setRedraw(true)

on Composites that contain controls it doesn't own.
Comment 3 Daniel Rolka CLA 2014-05-13 05:13:07 EDT 
(In reply to Markus Keller from comment #2)
> The pattern used in
> org.eclipse.e4.ui.css.swt.properties.css2.CSSPropertyFontSWTHandler.
> setFont(Widget, Font) is crazy: CSS code must not call
> 
>     control.setRedraw(false)
>     ...
>     control.setRedraw(true)
> 
> on Composites that contain controls it doesn't own.

The review link - https://git.eclipse.org/r/#/c/26431/

Daniel
Comment 4 Markus Keller CLA 2014-05-13 09:19:00 EDT 
(In reply to Daniel Rolka from comment #3)
> The review link - https://git.eclipse.org/r/#/c/26431/

Looks good, merged. Moving this bug to 4.5 for the other items.
Comment 5 Markus Keller CLA 2014-05-16 09:21:23 EDT 
> The review link - https://git.eclipse.org/r/#/c/26431/
This has been reverted, see e.g. bug 433858 comment 38 and bug 435024.
Comment 6 Lars Vogel CLA 2015-03-18 19:53:58 EDT 
I like to close this one as we have bug 401632 and bug 435024 for the detailed problems.