Bug 401327 - [MPE] AbstractMultiEditor.getInnerEditorContainer is never called
Summary: [MPE] AbstractMultiEditor.getInnerEditorContainer is never called
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2.1   Edit
Hardware: PC Linux-GTK
: P3 critical (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords: needinfo
Depends on:
Blocks: 396528
  Show dependency tree
 
Reported: 2013-02-20 11:00 EST by Kalvin Misquith CLA
Modified: 2015-05-27 04:01 EDT (History)
8 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kalvin Misquith CLA 2013-02-20 11:00:06 EST
I have a class which extends AbstractMultiEditor and overrides getInnerEditorContainer. This method is never called in 4.2. It was called in 3.6 by EditorManager.InnerEditor.getPaneControlContainer
Comment 1 Kalvin Misquith CLA 2013-02-20 12:16:38 EST
Also in 4.2, AbstractMultiEditor.innerEditorsCreated is called without invoking the createPartControl method in the internal editors (worked in 3.6).
Comment 2 Samantha Chan CLA 2013-04-02 14:29:28 EDT
Also marking this as critical as this blocks our migration to 4.2.
Comment 3 Paul Webster CLA 2013-04-02 14:46:38 EDT
I can try and look at this next week, but as we don't have an implementation of AbstractMultiEditor (bug 396528 ) in Kepler I don't think it'll get fixed (unless someone has some quick fixes they think will work in M7)

PW
Comment 4 Daniel Rolka CLA 2014-01-28 07:11:54 EST
(In reply to Kalvin Misquith from comment #0)
> I have a class which extends AbstractMultiEditor and overrides
> getInnerEditorContainer. This method is never called in 4.2. It was called
> in 3.6 by EditorManager.InnerEditor.getPaneControlContainer

Could you please provide a sample plugin with editor that shows your use case with the AbstractMultiEditor.getInnerEditorContainer method?

thanks,
Daniel
Comment 5 Dani Megert CLA 2014-02-03 10:10:00 EST
Please provide an example that allows to show reproduce the problem. Otherwise this will go out of 4.4.
Comment 6 Tomasz Zarna CLA 2015-03-23 17:07:49 EDT
You could add a simple test to MultiEditorTest verifying the API contract (call history), but that would indicate more issues with the multi-editor. I see failures in MultiEditorTestSuite, which currently doesn't seem to be executed. Looks like an API breakage to me.
Comment 7 Dani Megert CLA 2015-05-22 12:13:44 EDT
No answer was provided to comment 5.