Community
Participate
Working Groups
To reproduce, create an editor with a source viewer and mark the vertical ScrollBar of the StyledText of the source viewer invisible. i.e.: on a class derived from org.eclipse.jface.text.source.projection.ProjectionViewer, override: protected StyledText createTextWidget(Composite parent, int styles) { StyledText t = super.createTextWidget(parent, styles); t.getVerticalBar().setVisible(false); } then, open some editors, add some error annotations and resize the editor a bit: at some point the overview ruler will become wrong because it'll end up mixing the head/body because the method org.eclipse.jface.text.source.SourceViewer.RulerLayout.getVerticalScrollArrowHeights(StyledText, int) returns absurd values if the vertical bar is invisible. A possible fix would be changing: if (verticalBar == null) return new int[] { 0, 0 }; to if (verticalBar == null || !verticalBar.getVisible()) return new int[] { 0, 0 }; as the first thing in the getVerticalScrollArrowHeights method.
(In reply to comment #0) > To reproduce, create an editor with a source viewer and mark the vertical > ScrollBar of the StyledText of the source viewer invisible. Can you attach a test case / example?
Please reopen after attaching a sample / test case.
Not attaching test, but giving detailed instructions on how to reproduce this with a regular text editor (i.e.: editor for .txt files). Should be straightforward if you have the Eclipse sources there. 1. Override org.eclipse.jface.text.TextViewer.createTextWidget(Composite, int) to do styledText.getVerticalBar().setVisible(false): I.e.: protected StyledText createTextWidget(Composite parent, int styles) { StyledText styledText = new StyledText(parent, styles); styledText.getVerticalBar().setVisible(false); styledText.setLeftMargin(Math.max(styledText.getLeftMargin(), 2)); return styledText; } 2. Print the returned values at: org.eclipse.jface.text.source.SourceViewer.RulerLayout.getVerticalScrollArrowHeights(StyledText, int) I.e.: right after: int[] arrowHeights = computeScrollArrowHeights(textWidget, bottomOffset); add: System.out.println("Computed: "+arrowHeights[0]+" - "+arrowHeights[1]); 3. Change your annotations so that they appear in the overview ruler. 4. Open a text file (say, 20 lines repeating the string 'aaaa'), do a text search for 'aaaa' (so that annotations appear for each line in the overview ruler) and resize the editor vertically: you'll notice that the values printed are usually 0 and sometimes some absurd number. Another thing to observe is that the annotations in the overview ruler become totally wrong (although this seems to be a separate issue, as fixing it to return new int[] { 0, 0 } still has a weird behavior, although absurd values are no longer given there, also, it seems that the positions where I hover over the overview ruler no longer match the positions that they should match in the editor -- should I open another issue for that?).
OK, I see it now. The overview ruler was not implemented to work along with the scroll bar. Fixing the arrow height is one thing, but as you noted, the annotations will still be placed at wrong locations.
I'll try to come up with a patch to solve those issues (I actually have it working with the old OverviewRuler code, but it changed a lot from 3.x to 4.x, so, it's non-trivial porting that code, so, it may take a while). What would be the limit to have this incorporated into the final Eclipse 4.3?
(In reply to comment #5) > (I actually have it > working with the old OverviewRuler code, but it changed a lot from 3.x to > 4.x This statement is invalid. The JFace Text code is 100% identical for 3.x and 4.x. > What would be the limit to have this incorporated into the final Eclipse 4.3? I'd need it by April 15.
(In reply to comment #6) > (In reply to comment #5) > > (I actually have it > > working with the old OverviewRuler code, but it changed a lot from 3.x to > > 4.x > This statement is invalid. The JFace Text code is 100% identical for 3.x and > 4.x. You're right. I have a fix from an older version of the OverviewRuler (I had a fork of it to do some experiments on PyDev with a minimap).
Can you just change if (verticalBar == null) return new int[] { 0, 0 }; to if (verticalBar == null || !verticalBar.getVisible()) return new int[] { 0, 0 }; as the first thing in the org.eclipse.jface.text.source.SourceViewer.RulerLayout.getVerticalScrollArrowHeights method? (at least it'd allow me to fix things in a subclass later on if I miss the date and can only provide an actual fix for 4.4). If you need I can add a patch for that...
(In reply to comment #8) > Can you just change > > if (verticalBar == null) > return new int[] { 0, 0 }; > > to > > if (verticalBar == null || !verticalBar.getVisible()) > return new int[] { 0, 0 }; > > as the first thing in the > org.eclipse.jface.text.source.SourceViewer.RulerLayout. > getVerticalScrollArrowHeights method? (at least it'd allow me to fix things > in a subclass later on if I miss the date and can only provide an actual fix > for 4.4). > > If you need I can add a patch for that... Fixed with http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=67e1ed78a51efe5d1182de6bb9f98631a3e9841c
(In reply to Dani Megert from comment #9) > Fixed with > http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/ > ?id=67e1ed78a51efe5d1182de6bb9f98631a3e9841c Should the bug marked as fixed?
No, the original request is not totally fulfilled (that's just the first building block for it). I still haven't been able to properly investigate the code to see why it's not working properly to produce a proper patch (what I know is that it did work properly some point in the past and stopped working with some of the latest changes in the overview ruler)...
*** This bug has been marked as a duplicate of bug 490951 ***
As a note, this issue is fixed in the gerrit review submitted for #490951 (so, marking this one as a duplicate).
