Bug 400129 - [ua] NPE when registering context help for non-plugin project
Summary: [ua] NPE when registering context help for non-plugin project
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.3 M6   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks: 401435
  Show dependency tree
 
Reported: 2013-02-06 12:30 EST by Szymon Ptaszkiewicz CLA
Modified: 2013-02-21 09:57 EST (History)
2 users (show)

See Also:
curtis.windatt.public: review+

Attachments
Log with NPE (4.11 KB, text/plain)
2013-02-06 12:30 EST, Szymon Ptaszkiewicz CLA 		no flags Details
Fix analogous to the fix for bug 273049 (1.81 KB, patch)
2013-02-06 13:17 EST, Szymon Ptaszkiewicz CLA 		curtis.windatt.public: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Ptaszkiewicz CLA 2013-02-06 12:30:08 EST 
Created attachment 226651 [details]
Log with NPE

It is wrong to register context help for a non-plugin project, but the error message could be more descriptive than NPE.

Steps to reproduce:
1. Create new General Project.
2. Create new Context Help in that project.
3. Click "Register this context help file" in the top right corner of Context Help Editor.
4. Click Finish.
=> Error dialog with NPE appears.

Similar to bug 273049 comment 3.
Comment 1 Szymon Ptaszkiewicz CLA 2013-02-06 13:17:16 EST 
Created attachment 226653 [details]
Fix analogous to the fix for bug 273049
Comment 2 Szymon Ptaszkiewicz CLA 2013-02-06 13:19:06 EST 
Curtis, please review when you get a moment. Thanks!
Comment 3 Curtis Windatt CLA 2013-02-06 13:53:49 EST 
Fixed in master
http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=04501d661416491d08387b4825bf9ff11bfb832e

I also fixed the duplicate NPE in the table of contents editor.  The formatter made a number of extra changes to the file.  I updated the x-friends so this change didn't add a warning.
Comment 4 Ivy Ho CLA 2013-02-20 09:49:04 EST 
Hi  Syzmon: can you please help to open an IES bugzilla? The RAD team said that they will need this IES bugzilla number so that they can pick up the fix.
Thanks so much.