Bug 273049 - [CheatSheet] Registering a cheat sheet fails with java.lang.NullPointerException
Summary: [CheatSheet] Registering a cheat sheet fails with java.lang.NullPointerException
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4.2   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-21 06:50 EDT by Dirk Osswald CLA
Modified: 2009-04-21 17:29 EDT (History)
2 users (show)

See Also:


Attachments
Patch (1.37 KB, patch)
2009-04-21 16:13 EDT, Benjamin Cabé CLA
caniszczyk: iplog+
Details | Diff
mylyn/context/zip (1.73 KB, application/octet-stream)
2009-04-21 16:14 EDT, Benjamin Cabé CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Osswald CLA 2009-04-21 06:50:55 EDT
When editing a CheatSheet the button "Register this cheet sheet" opens a window where you can enter a (new) category and a description.
When doing so and then clicking "Finish" a popup "Problem Occured" comes up saying "java.lang.NullPointerException". (no more details)

The cheat sheet is not registered after this.
Comment 1 Benjamin Cabé CLA 2009-04-21 08:17:25 EDT
I'm afraid I cannot reproduce it. Could you please try to see if there is something logged in the 'Error Log' view?
Comment 2 Dirk Osswald CLA 2009-04-21 10:51:36 EDT
Thanks to the "Error log" view hint here is some more info:

Exception Stack Trace:
java.lang.NullPointerException
at org.eclipse.pde.internal.ui.wizards.cheatsheet.RegisterCSOperation.execute(RegisterCSOperation.java:78)
at org.eclipse.ui.actions.WorkspaceModifyOperation$1.run(WorkspaceModifyOperation.java:104)
at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:1800)
at org.eclipse.ui.actions.WorkspaceModifyOperation.run(WorkspaceModifyOperation.java:116)
at org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
at org.eclipse.jface.wizard.WizardDialog.run(WizardDialog.java:934)
at org.eclipse.pde.internal.ui.wizards.cheatsheet.RegisterCSWizard.performFinish(RegisterCSWizard.java:60)
at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:742)
at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:373)
at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:624)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:228)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1003)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3823)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3422)
at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
at org.eclipse.jface.window.Window.open(Window.java:801)
at org.eclipse.pde.internal.ui.editor.cheatsheet.CSAbstractEditor.handleLinkActivatedRegisterCS(CSAbstractEditor.java:117)
at org.eclipse.pde.internal.ui.editor.cheatsheet.CSAbstractEditor.access$3(CSAbstractEditor.java:107)
at org.eclipse.pde.internal.ui.editor.cheatsheet.CSAbstractEditor$2.linkActivated(CSAbstractEditor.java:71)
at org.eclipse.ui.forms.widgets.AbstractHyperlink.handleActivate(AbstractHyperlink.java:228)
at org.eclipse.ui.forms.widgets.ImageHyperlink.handleActivate(ImageHyperlink.java:177)
at org.eclipse.ui.forms.widgets.AbstractHyperlink.handleMouseUp(AbstractHyperlink.java:322)
at org.eclipse.ui.forms.widgets.AbstractHyperlink.access$2(AbstractHyperlink.java:306)
at org.eclipse.ui.forms.widgets.AbstractHyperlink$4.handleEvent(AbstractHyperlink.java:120)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1003)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3823)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3422)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2384)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2348)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2200)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:495)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:288)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:490)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:113)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:193)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:386)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:549)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:504)
at org.eclipse.equinox.launcher.Main.run(Main.java:1236)



Session Data:

eclipse.buildId=M20090211-1700
java.version=1.6.0_13
java.vendor=Sun Microsystems Inc.
BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=de_DE
Framework arguments:  256M
Command-line arguments:  -os win32 -ws win32 -arch x86 256M -data D:\home\osswald2\SCHUNK\SDH2\SDHLibrary

This is a continuation of log file D:\home\osswald2\SCHUNK\SDH2\SDHLibrary\.metadata\.bak_2.log
Created Time: 2009-04-17 20:33:33.937
Comment 3 Benjamin Cabé CLA 2009-04-21 11:01:07 EDT
OK, thanks! I can easily reproduce on 3.5: the error occurs when the project containing the Cheatsheet is not a Plug-in project...
Comment 4 Benjamin Cabé CLA 2009-04-21 16:13:26 EDT
Created attachment 132666 [details]
Patch

Don't add the "register this cheatsheet" action in the toolbar if the current project is not a plug-in project...
Trivial enough for an inclusion in M7 IMO
Comment 5 Benjamin Cabé CLA 2009-04-21 16:14:41 EDT
Created attachment 132667 [details]
mylyn/context/zip
Comment 6 Chris Aniszczyk CLA 2009-04-21 17:29:14 EDT
done.

> 20090421

In the future, we may want to consider moving this logic up the chain.