Community
Participate
Working Groups
Arrows created in bug 398594 could be easier to hit
This change just increases the size of the mouse rectangle to that of the buttons, which makes them much easier to use. https://git.eclipse.org/r/#/c/10128/
what would also be nice if the 2 buttons that we see now would show if the current change is active (so you selected it, the box around it are darker) The you can just select it in the editor and they would popup.
Johan: You mean that when you select/click one of the lines belonging to a change in the text editor, it would show the buttons directly without having to hover over the middle part? I could look into that, but it should probably be done in a separate change.
yes that looks way more easier to me, for users 1 big area that you can select and then the buttons appear directly Without needing to hover over some place.
I think Johan's idea is very nice and improves discoverability. I added an implementation of it to the existing patch: https://git.eclipse.org/r/#/c/10128/ Malgorzata, what do you think?
Is it still possible for this to get into 4.3? Any comments on the review?
Tomasz, could you maybe do a review?
(In reply to comment #7) > Tomasz, could you maybe do a review? Tomasz is still a committer, but he unfortunately changed his responsibilities while moving to a different company.
(In reply to Robin Stocker from comment #3) > Johan: You mean that when you select/click one of the lines belonging to a > change in the text editor, it would show the buttons directly without having > to hover over the middle part? I could look into that, but it should > probably be done in a separate change. You are right, this should be done in a separate change. We can use this bug according to its initial purpose and fix it with the change proposed in Patch Set 3 of https://git.eclipse.org/r/#/c/10128/ Robin, can you please split the proposed change into two so that this bug can be fixed with a change along the lines of Patch Set 3 and then propose another change for bug 442177. Thanks!
(In reply to Szymon Ptaszkiewicz from comment #9) > You are right, this should be done in a separate change. Oh no, why did I say that ;). I think I did it in the same change because I noticed that none of the code of the first part was left when I had finished the second part. I can do that, but the second change will more or less remove everything that the first change did and do it differently. So if that's ok for you, I can look into that.
(In reply to Robin Stocker from comment #10) > (In reply to Szymon Ptaszkiewicz from comment #9) > > You are right, this should be done in a separate change. > > Oh no, why did I say that ;). I think I did it in the same change because I > noticed that none of the code of the first part was left when I had finished > the second part. > > I can do that, but the second change will more or less remove everything > that the first change did and do it differently. So if that's ok for you, I > can look into that. Yes, please do. I have reviewed the other part as well but I was not quite convinced that's the simplest change possible, so it would be better to fix it separately.
Done, see newest patch set and the change for bug 442177.
Fixed in master with: http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=b87ba2186f8e7b6b0c6e7cfbd47a7604f69f17eb Thanks, Robin!
