Bug 399700 - [navigator] [editor] [model] remove coupling between editor and navigator
Summary: [navigator] [editor] [model] remove coupling between editor and navigator
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 2.0   Edit
Assignee: Miles Parker CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 400165 400356
Blocks:
  Show dependency tree
 
Reported: 2013-01-31 20:04 EST by Miles Parker CLA
Modified: 2013-04-19 02:43 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Miles Parker CLA 2013-01-31 20:04:19 EST 
Currently, because the editor manages actual patch set loads, we need to notify the navigator when the editor is created (1) and when we have completed patch set load (2). These couplings should be removed.

Since this coupling was driven in the first place by the coupling between the editor and creating the model from the Gerrit API, we should probably address this after bug 394020. Then both the editor and viewer would recieve notifications from the Gerrit model when the patch sets are updated.

1) https://git.eclipse.org/r/#/c/8732/32/org.eclipse.mylyn.gerrit.ui/src/org/eclipse/mylyn/internal/gerrit/ui/editor/GerritTaskEditorPage.java refreshExplorer
2) https://git.eclipse.org/r/#/c/8732/32/org.eclipse.mylyn.gerrit.ui/src/org/eclipse/mylyn/internal/gerrit/ui/editor/PatchSetSection.java L 396
Comment 1 Miles Parker CLA 2013-01-31 20:08:44 EST 
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=334967#c26 and replies for more context.
Comment 2 Miles Parker CLA 2013-02-07 17:40:47 EST 
(No longer has soft dependency on bug 394020.)
Comment 3 Miles Parker CLA 2013-03-08 19:57:59 EST 
See bug 400270 comment 9 and https://git.eclipse.org/r/#/c/11012/ for experimental implementation. 

Nav is not owrking yet -- we're going to need a whole service (perhaps extension point) for getting the remote factory for Review implementations.
Comment 4 Miles Parker CLA 2013-04-11 23:30:51 EDT 
Addressed in https://git.eclipse.org/r/#/c/11012 -- see bug 400168 comment 2.
Comment 5 Miles Parker CLA 2013-04-18 18:00:54 EDT 
Fixed in: https://git.eclipse.org/r/#/c/11012/