Bug 397986 - Convert Team popupMenus contributions to org.eclipse.ui.menus contributions
Summary: Convert Team popupMenus contributions to org.eclipse.ui.menus contributions
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 4.2.1   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform Team Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 405237
Blocks: 175693
  Show dependency tree
 
Reported: 2013-01-11 10:48 EST by Richard Birenheide CLA
Modified: 2013-11-17 11:08 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Birenheide CLA 2013-01-11 10:48:32 EST
Currently the Team actions (where one would provide ones own team provider actions) are defined using org.eclipse.ui.popupMenus. If a team provider wishes to contribute to that using org.eclipse.ui.menus he is forced to redefine the exact menu structure in his provisioning plugin, otherwise his contributions will not show up or the order of the existing contributions gets wild (if not the entire structure is redefined). For example like in the excerpt from plugin.xml at the bottom of the message. This has two issues: 

1. The exact order may play a role. Also, this might break, if the Team plugin changes its definition in future versions.

2. Another team provider might do the same redefinitions. This may lead to undesired behaviour as well.

Therefore I am asking to convert the existing popupMenus to org.eclipse.ui.menus. If you want to avoid converting actions to handlers, it possibly might be sufficient just to add the contributions below. This at least would give team provider implementors an easy path to using handlers.

Regards
Richard

 <menuContribution
            allPopups="true"
            locationURI="popup:org.eclipse.ui.popup.any">
         <menu
               id="team.main"
               label="Team">
            <separator
                  name="group1"
                  visible="true">
            </separator>
            <separator
                  name="applyPatchGroup"
                  visible="true">
            </separator>
            <separator
                  name="group2"
                  visible="true">
            </separator>
            <separator
                  name="group3"
                  visible="true">
            </separator>
            <separator
                  name="group4"
                  visible="true">
            </separator>
            <separator
                  name="group5"
                  visible="true">
            </separator>
            <separator
                  name="group6"
                  visible="true">
            </separator>
            <separator
                  name="group7"
                  visible="true">
            </separator>
            <separator
                  name="group8"
                  visible="true">
            </separator>
            <separator
                  name="group9"
                  visible="true">
            </separator>
            <separator
                  name="group10"
                  visible="true">
            </separator>
            <separator
                  name="targetGroup"
                  visible="true">
            </separator>
            <separator
                  name="projectGroup"
                  visible="true">
            </separator>
         </menu>
      </menuContribution>
Comment 1 Robin Stocker CLA 2013-11-17 11:08:08 EST
+1, see also bug 175693 and bug 405237 (possible duplicates).