Bug 397837 - Add HandlerProcessingAddon information to 4.3 migration guide
Summary: Add HandlerProcessingAddon information to 4.3 migration guide
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Windows 8
: P3 normal with 1 vote (vote)
Target Milestone: 4.3 RC3   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
: 399657 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-01-10 05:31 EST by Emilio Sansano CLA
Modified: 2013-06-05 10:13 EDT (History)
7 users (show)

See Also:

Attachments
Patch (1.56 KB, text/plain)
2013-05-29 10:19 EDT, Nobody - feel free to take it CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emilio Sansano CLA 2013-01-10 05:31:25 EST 
This code:

Map<String, String> parameter = new HashMap<String, String>();
parameter.put(PARAMETER_SWITCHPERSPECTIVE_ID, PERSPECTIVE_ID);
ParameterizedCommand command = commandService.createCommand(COMMAND_SWITCHPERSPECTIVE_ID, parameter);
handlerService.executeHandler(command);

was working fine with Eclipse 4.3M3. After updating to 4.3M4 it doesn't work anymore, the handler is not being executed. 

Reverting eclipse to previous version makes it work again.
Comment 1 Mario Manno CLA 2013-01-10 06:29:55 EST 
I can confirm these, my @CanExecute methods arn't called either.
Comment 2 Paul Webster CLA 2013-01-11 08:16:55 EST 
If you have an existing model, you have to add org.eclipse.e4.ui.internal.workbench.addons.HandlerProcessingAddon to your model, similar to how it is in eclipse/plugins/org.eclipse.platform_4.3.0.v201212140730/LegacyIDE.e4xmi

PW
Comment 3 Emilio Sansano CLA 2013-01-11 09:29:20 EST 
Thank you Paul, adding the addon to the model as it is in LegacyIDE.e4xmi solves the problem.
Comment 4 Paul Webster CLA 2013-02-01 08:50:23 EST 
*** Bug 399657 has been marked as a duplicate of this bug. ***
Comment 5 Nobody - feel free to take it CLA 2013-02-04 05:43:04 EST 
Paul, where can I edit the migration guide and add this info? I feel I should do it since I made the change.
Comment 6 Paul Webster CLA 2013-02-04 11:36:43 EST 
We work in master in http://git.eclipse.org/c/platform/eclipse.platform.common.git/tree/bundles/org.eclipse.platform.doc.isv/porting

I have to talk to some developers though.  If a 3.x RCP app based on 4.2 doesn't work by default in 4.3, we might have to add some workbench code to "auto-upgrade" the existing model.

PW
Comment 7 Nobody - feel free to take it CLA 2013-04-12 05:00:29 EDT 
Paul I'm trying to clear my assigned bugs list. Is it appropriate to add now the info on the new addon?
Comment 8 Paul Webster CLA 2013-05-27 10:27:48 EDT 
We need to get this in this week.

PW
Comment 9 Nobody - feel free to take it CLA 2013-05-29 10:19:03 EDT 
Created attachment 231697 [details]
Patch
Comment 11 Eric Moffatt CLA 2013-06-05 10:13:14 EDT 
Verified (visually) that the new section is in the docs...