Description Jonathan Jekeli 2012-12-17 15:06:53 EST

Not certain what version of jface I am using (I am in eclipse Juno using eclipse rcp 4.2.1).  I created a custom jface.DialogCellEditor. In ColumnViewerEditor.activateCellEditor, there is the following code (lines 198-210):

~~~
// Tricky flow of control here:
// activate() can trigger callback to cellEditorListener which
// will clear cellEditor
// so must get control first, but must still call activate()
// even if there is no control.
final Control control = cellEditor.getControl();
cellEditor.activate(activationEvent);
if (control == null) {
    return false;
}
setLayoutData(cellEditor.getLayoutData());
setEditor(control, (Item) cell.getItem(), cell.getColumnIndex());
cellEditor.setFocus();
~~~

From the comment, it is clear that it is known that the activate() call can change cellEditor to null.  In my case (cellEditor is the custom DialogCellEditor), it does, and as a result I get a NullPointerException on setLayoutData(cellEditor.getLayoutData());

This starts from a programmatic activation of the cell using ColumnViewer.editElement()

I can post code if necessary.  This NPE doesn't seem to affect anything on the surface, but I am worried there might be some behind the scenes stuff affected.

Thanks.