Bug 396332 - html cleaner should validate and repair CSS colour styles
Summary: html cleaner should validate and repair CSS colour styles
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.7.3   Edit
Assignee: Billy Huang CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2012-12-11 16:17 EST by Billy Huang CLA
Modified: 2012-12-17 13:21 EST (History)
1 user (show)

See Also:


Attachments
mylyn/context/zip (6.23 KB, application/octet-stream)
2012-12-12 19:33 EST, David Green CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Billy Huang CLA 2012-12-11 16:17:02 EST
If a CSS "color" style is missing a "#" prefix, the color is used as-is. The html cleaner should detect these cases and repair them if possible.
Comment 1 David Green CLA 2012-12-12 15:48:23 EST
review: https://git.eclipse.org/r/#/c/9161/
Comment 2 David Green CLA 2012-12-12 19:33:51 EST
thanks for the excellent contribution Billy.  Review has been merged.
Comment 3 David Green CLA 2012-12-12 19:33:54 EST
Created attachment 224652 [details]
mylyn/context/zip
Comment 4 Steffen Pingel CLA 2012-12-15 14:00:18 EST
I cherry picked these two commits to the e_3_8_m_3_8_x branch:

7596c3353be229c843d4a99177a84fe146aa36b0
dfcbab49d4f7ca4b58201678145d414b65b4739f
Comment 5 David Green CLA 2012-12-17 13:21:39 EST
Thanks Steffen