Bug 394733 - Add number of patches and 'Reviewers' matrix to the task list tooltip
Summary: Add number of patches and 'Reviewers' matrix to the task list tooltip
Status: ASSIGNED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Jaxsun McCarthy Huggan CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-21 01:38 EST by Minoo Ziaei CLA
Modified: 2018-11-30 17:49 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Minoo Ziaei CLA 2012-11-21 01:38:30 EST 
Currently when we hover over a task summary in the task list, tooltip doesn't show information regarding the votes on the review. It may not be a bad idea to have the votes on the latest patch as well as the number of overall patches as part of the tooltip.
Will attach the patch shortly.
Comment 1 Minoo Ziaei CLA 2012-11-21 02:22:28 EST 
I could think of two approaches here:
1- Retrieving and parsing json data of org.eclipse.gerrit.Review attribute as part of TaskListToolTip class or an extension of it, as GerritUtil does.
2- Extracting the voting info simply from inside the GerritConnector class and add it to the ATTRIBUTE_TASK_EXTENDED_TOOLTIP attribute and then just simply retrieve value of this attribute in TaskListToolTip.
Comment 2 Steffen Pingel CLA 2012-11-22 04:43:57 EST 
There is currently no responsibility (In reply to comment #1)
> I could think of two approaches here:
> 1- Retrieving and parsing json data of org.eclipse.gerrit.Review attribute
> as part of TaskListToolTip class or an extension of it, as GerritUtil does.

There is not extensibility in the tooltip class to execute connector specific code at the moment.

> 2- Extracting the voting info simply from inside the GerritConnector class
> and add it to the ATTRIBUTE_TASK_EXTENDED_TOOLTIP attribute and then just
> simply retrieve value of this attribute in TaskListToolTip.

I would prefer doing that.
Comment 3 Steffen Pingel CLA 2012-11-24 07:38:15 EST 
(In reply to comment #2)
> > 2- Extracting the voting info simply from inside the GerritConnector class
> > and add it to the ATTRIBUTE_TASK_EXTENDED_TOOLTIP attribute and then just
> > simply retrieve value of this attribute in TaskListToolTip.
> 
> I would prefer doing that.

That said, the Gerrit voting maybe too complex to display concisely as text and could be a good use case for providing extensibility for custom tooltip content. That would be a larger effort though requiring a new extension point etc.
Comment 4 Miles Parker CLA 2012-11-26 13:31:33 EST 
(In reply to comment #2)
> There is currently no responsibility (In reply to comment #1)
> > I could think of two approaches here:
> > 1- Retrieving and parsing json data of org.eclipse.gerrit.Review attribute
> > as part of TaskListToolTip class or an extension of it, as GerritUtil does.
> 
> There is not extensibility in the tooltip class to execute connector specific
> code at the moment.
> 
> > 2- Extracting the voting info simply from inside the GerritConnector class
> > and add it to the ATTRIBUTE_TASK_EXTENDED_TOOLTIP attribute and then just
> > simply retrieve value of this attribute in TaskListToolTip.
> 
> I would prefer doing that.

I think we could consider adding these values to the Review model object. As approvals are basically connector specific, we will probably want to provide a reference to an interface for this. Then we could grab this data from the modeled objects, using a customized model label provider.
Comment 5 Miles Parker CLA 2013-04-18 18:14:11 EDT 
> (In reply to comment #2)
> I think we could consider adding these values to the Review model object. As
> approvals are basically connector specific, we will probably want to provide a
> reference to an interface for this. Then we could grab this data from the
> modeled objects, using a customized model label provider.

The model side implementation of this is done. See bug 404933
Comment 6 Miles Parker CLA 2013-06-19 20:37:37 EDT 
Marking as an enhancement (so I don't keep seeing it in my list of outstanding bugs.. :))

Given issues above, do we still want to leave this open? We could retrieve the model when we open the popup. Wouldn't be *that* hard to accomplish. Personally, I'd find this information useful.
Comment 7 Jaxsun McCarthy Huggan CLA 2016-10-27 18:37:07 EDT 
Since this bug was last active we've started recording some concise review vote information on review tasks, I think it would be wise to display this in the task list tooltip.
Comment 8 Eclipse Genie CLA 2016-10-27 18:45:15 EDT 
New Gerrit change created: https://git.eclipse.org/r/84052
Comment 9 Eclipse Genie CLA 2016-10-28 00:42:08 EDT 
New Gerrit change created: https://git.eclipse.org/r/84062
Comment 10 Eclipse Genie CLA 2016-10-29 19:13:38 EDT 
New Gerrit change created: https://git.eclipse.org/r/84171
Comment 11 Eclipse Genie CLA 2016-10-30 18:16:34 EDT 
New Gerrit change created: https://git.eclipse.org/r/84195