Bug 39392 - Replace AvoidableMessageDialog with MessageDialogWithToggle
Summary: Replace AvoidableMessageDialog with MessageDialogWithToggle
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Krzysztof Daniel CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2003-06-26 15:04 EDT by Dean Roberts CLA
Modified: 2007-06-05 15:17 EDT (History)
0 users

See Also:

Attachments
Replacement (3.60 KB, patch)
2007-03-19 06:27 EDT, Krzysztof Daniel CLA 		no flags Details | Diff
Replacement 2 (4.29 KB, patch)
2007-03-19 11:09 EDT, Krzysztof Daniel CLA 		no flags Details | Diff
mylar/context/zip (34.48 KB, application/octet-stream)
2007-03-19 11:09 EDT, Krzysztof Daniel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Roberts CLA 2003-06-26 15:04:06 EDT 
Both AvoidableMessageDialog and MessageDialogWithToggle are defined in Team 
but provide the same functionality.

MessageDialogWithToggle is a copy of an interna UI class that provides this 
functionality and thus, is a little better thought out and a better 
implementaiton.

I have entered another bug against UI saying that they should make this public 
API since it is used by UI, Team and ExternalTools.
Comment 1 Jean-Michel Lemieux CLA 2004-06-11 16:50:07 EDT 
Post 3.0
Comment 2 Michael Valenta CLA 2006-06-14 13:54:19 EDT 
We shoould do this as part of our plan to more up to the latst API provided by Platform UI (i.e. I believe that the MessageDialogWithToggle in UI is now API).
Comment 3 Krzysztof Daniel CLA 2007-03-19 06:27:57 EDT 
Created attachment 61266 [details]
Replacement

I have found only one appearance of AvoidableMessageDialog
Comment 4 Michael Valenta CLA 2007-03-19 09:57:45 EDT 
The patch is missing a string variable on CVSUIMessages so I get a compile error when I apply it.
Comment 5 Krzysztof Daniel CLA 2007-03-19 11:09:06 EDT 
Created attachment 61288 [details]
Replacement 2
Comment 6 Krzysztof Daniel CLA 2007-03-19 11:09:11 EDT 
Created attachment 61289 [details]
mylar/context/zip
Comment 7 Michael Valenta CLA 2007-03-21 11:46:56 EDT 
Patch released to HEAD with AvoidableMessageDialog deleted.
Comment 8 Michael Valenta CLA 2007-05-01 10:14:41 EDT 
Verified in I20070501-0010