Bug 393788 - show parent commit of each patch set in review editor
Summary: show parent commit of each patch set in review editor
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: 2.6   Edit
Assignee: Nicholas Folk CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed, noteworthy
Depends on:
Blocks:
 
Reported: 2012-11-07 11:35 EST by Sam Davis CLA
Modified: 2015-01-22 17:27 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Davis CLA 2012-11-07 11:35:59 EST 
It would be useful to show the parent of each patch set in the review editor like the web ui does, to make it easy to see when patch sets can not easily be compared. If space is a concern, a more compact, 2 column layout could be used:

|Author | Commiter|
|Commit | Ref	|
|Parent(s)|
Comment 1 Steffen Pingel CLA 2012-11-07 12:30:38 EST 
Sounds like a good idea to me.
Comment 2 Sam Davis CLA 2013-07-09 14:30:31 EDT 
Miles, do you know if this information is easily accessible?
Comment 3 Miles Parker CLA 2013-07-09 15:02:00 EDT 
I don't think we have that notion in the model itself, but it shouldn't be too hard to add. Seems analagous to the way we handle dependencies, right?
Comment 4 Sam Davis CLA 2015-01-22 17:27:27 EST 
The changes have been merged. Thanks Nicholas and Miles!

40065: 393788: add parent commits to the ecore model [I7602045f]
https://git.eclipse.org/r/#/c/40065/

38729: 393788: show parent commit of each patch set in review editor [I375bce95]
https://git.eclipse.org/r/#/c/38729/