Community
Participate
Working Groups
By pure chance (well, not really ... more from some surprising questions I received) I've noticed that Mylyn is, apparently, pulling into Juno this bundle from the platform: org.eclipse.core.runtime.compatibility.auth Such as by looking at https://hudson.eclipse.org/hudson/view/Repository%20Aggregation/job/simrel.juno.runAggregator/673/consoleFull and working backwards up the log file, I see Mirroring artifacts from file:///home/data/httpd/download.eclipse.org/mylyn/snapshots/3.8 Granted, we (platform) do distribute it in "3.8.x", but we do not in "4.2.x". See https://bugs.eclipse.org/bugs/show_bug.cgi?id=336129 So ... just thought I'd point this out to you. I am guessing you do not really need it? Or ... do you? Not sure what to recommend for Juno SR2 ... on the one hand, it should not be there ... but ... risky to remove things in a maintenance release. So ... I am opening this bug for your awareness and our discussion. And, for sure woudl recommend it not be in Kepler, which it currently is, I assume still pulled in by Mylyn?
Mylyn relies on the old keystore to persist credentials. We have had plans to migrate to the secure store for a while but ran into dead locks (bug 357278) so we postponed the migration. When platform stopped distributing the legacy keystore we put it on the Mylyn repository as a stop gap measure. Given that SR2 is around the corner and switching keystore APIs is a major change (and risk) for us I am afraid we won't be able to complete this for Juno. The current Kepler snapshot builds still rely on the old keystore but I'll make sure that migrating to the secure store is the Kepler plan (bug 278474) and will bring this up during the next Mylyn call to discuss how to proceed. Please let me know if you need more information or if I missed any of the questions.
Unfortunately, we were not able to resolve bug 278474 in the Kepler time frame. We will take another pass at this in the next release cycle so we can hopefully remove the legacy authentication support for Luna.
Sam, what are your thoughts on removing the compatibility feature from the Luna repository and EPP packages now?
I think the goal should be to remove it for 3.12. I don't know about the timing of the change but we should probably at least wait until some time after 3.11 is released in case any issues come up with the secure storage.
(In reply to comment #4) > I think the goal should be to remove it for 3.12. I don't know about the timing > of the change but we should probably at least wait until some time after 3.11 is > released in case any issues come up with the secure storage. That sounds good. Let's do that in master right away after Luna M6 (March 12). Then we can test the change with M7.
Ok.
I've created the following reviews: 23426: 393722: remove org.eclipse.core.runtime.compatibility.auth from tasks [I66de2bc6] https://git.eclipse.org/r/#/c/23426/ 23427: 393722: remove org.eclipse.core.runtime.compatibility.auth from commons [I37f3eac8] https://git.eclipse.org/r/#/c/23427/ I think we should keep it in our targets for now since we run migration tests against it.
Tomek, could you remove the compatibility feature from all EPP packages and from Mylyn's Luna contribution file?
Sure, but I don't see the feature to be present in any EPP package.
(In reply to comment #9) > Sure, but I don't see the feature to be present in any EPP package. Even better :). Then this the compatiblity.auth bundle should go away once https://git.eclipse.org/r/#/c/23426/ is merged and a 3.12 snapshot build is available.
(In reply to Steffen Pingel from comment #8) > remove the compatibility feature (...) from Mylyn's Luna contribution file http://git.eclipse.org/c/simrel/org.eclipse.simrel.build.git/commit/?id=09472df932320697bce584707f8a90af73a4d462 => https://hudson.eclipse.org/hudson/job/simrel.luna.runaggregator/389/
(In reply to comment #10) > (In reply to comment #9) > > Sure, but I don't see the feature to be present in any EPP package. > > Even better :). Then this the compatiblity.auth bundle should go away once > https://git.eclipse.org/r/#/c/23426/ is merged and a 3.12 snapshot build is > available. The change is merged.
Oops, now it really is merged.
Sam, should we close this bug? There is bug 431636 to track removal of the feature for the release following 3.12.
No, we should test the luna build and confirm that the plugin is actually removed.
*** Bug 385421 has been marked as a duplicate of this bug. ***
I've confirmed that the org.eclipse.core.runtime.compatibility.auth bundle is not in the Luna M7 Java EE package, which includes Mylyn. So we're done here!
