Bug 392366 - make gdk_drawable_get_image dynamic
Summary: make gdk_drawable_get_image dynamic
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.3 M3   Edit
Assignee: Silenio Quarti CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 340067
  Show dependency tree
 
Reported: 2012-10-18 14:11 EDT by Anatoly Spektor CLA
Modified: 2012-10-24 14:46 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anatoly Spektor CLA 2012-10-18 14:11:46 EDT 
This patch makes gdk_drawable_get_image dynamic:

http://fedorapeople.org/cgit/aspektor/public_git/eclipse.platform.swt.git/commit/?h=gtk3_drawable_get_image

Note:

I am hesitant about the TrayItem.gtk_size_allocate use of gdk_drawable_get_image.

Tests I made:

To test if TrayItem.gtk_size_allocate() is called I have ran following snippets (with commented out gtk_size_allocate):

http://git.eclipse.org/c/platform/eclipse.platform.swt.git/tree/examples/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets/Snippet143.java

http://www.java2s.com/Tutorial/Java/0280__SWT/Createaballoontooltipforatrayitem.htm

and ControlExample (Tooltip tab has "Show in Tray" option)

None of them called gtk_size_allocate, thus I made a conclusion that probably this function is not used.

If I am wrong, please let me know.
Comment 1 Alexander Kurtakov CLA 2012-10-23 17:02:07 EDT 
Silenio, would you please comment on the TrayItem and gtk_size_request concern?
Comment 2 Silenio Quarti CLA 2012-10-24 12:46:56 EDT 
(In reply to comment #1)
> Silenio, would you please comment on the TrayItem and gtk_size_request
> concern?

Unfortunately, TrayItem icon does not work on RedHat 6 and Ubuntu 12.  It works on RedHat 5 (gtk 2.10), but that code only runs for GTK < 2.10 (see hookEvents()). So we are safe to make it dynamic.

Fixed
http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=349459091b102fd601c4529f951a9f14324c71bd