Bug 392223 - Use gdk_pixbuf_get_from_window instead of gdk_pixbuf_get_from_drawable for GTK+ 3
Summary: Use gdk_pixbuf_get_from_window instead of gdk_pixbuf_get_from_drawable for GT...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.3 M3   Edit
Assignee: Alexander Kurtakov CLA
QA Contact:
URL:
Whiteboard: gtk3test
Keywords:
Depends on:
Blocks: 340067
  Show dependency tree
 
Reported: 2012-10-17 16:23 EDT by Anatoly Spektor CLA
Modified: 2012-10-24 14:46 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anatoly Spektor CLA 2012-10-17 16:23:28 EDT 
This patch replaces gdk_pixbuf_get_from_drawable with gdk_pixbuf_get_from_window for GTK+ 3 :

http://fedorapeople.org/cgit/aspektor/public_git/eclipse.platform.swt.git/commit/?h=gtk3_pixbuf_ftom_drawable

I've used as a source:

http://developer.gnome.org/gtk3/3.3/ch25s02.html
and  https://mail.gnome.org/archives/commits-list/2010-September/msg05645.html
Comment 1 Alexander Kurtakov CLA 2012-10-17 17:07:45 EDT 
Correct by the porting document and doesn't affect Gtk2. Pushed to master.
http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=5673881707cbfd963bc0ed943607494119f5edb9
Comment 2 Silenio Quarti CLA 2012-10-18 10:43:11 EDT 
The patch is ok, but we could just make the old API dynamic, since all the calls are in the not OS.USE_CAIRO code patch.