Bug 391459 - cannot press/toggle Button with Space key any more
Summary: cannot press/toggle Button with Space key any more
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.3   Edit
Hardware: PC Linux-GTK
: P3 normal (vote)
Target Milestone: 4.3 M3   Edit
Assignee: Silenio Quarti CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2012-10-09 12:37 EDT by Markus Keller CLA
Modified: 2012-10-31 09:47 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2012-10-09 12:37:17 EDT 
Version: 4.3.0
Build id: I20121009-0800
GTK 32-bit

I cannot press/toggle a Button with the Space key any more. Works fine in 3.8.
Comment 1 Anatoly Spektor CLA 2012-10-12 12:23:17 EDT 
(In reply to comment #0)
> Version: 4.3.0
> Build id: I20121009-0800
> GTK 32-bit
> 
> I cannot press/toggle a Button with the Space key any more. Works fine in
> 3.8.

Hey Markus,

Can you please post a snippet/test program that you are using, that shows the problem ?

Thanks,

Anatoly
Comment 2 Markus Keller CLA 2012-10-12 13:46:58 EDT 
Just use any program that creates an SWT Button, e.g. ControlExample or the Eclipse Preferences dialog. Press the Tab key until a button is highlighted, and then press Space.

Happens for all kinds of buttons (CHECK, TOGGLE, PUSH, RADIO).
Comment 3 Alexander Kurtakov CLA 2012-10-15 15:59:46 EDT 
This was caused by http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=775e69f0ceacc29119a99a55a08648607c8bbff3 . Silenio as you're the one that did the changes can you take a look, I have no idea what your changes were supposed to do.
Comment 4 Silenio Quarti CLA 2012-10-22 12:01:41 EDT 
Those changes where made to fix bug#381974.
Comment 5 Silenio Quarti CLA 2012-10-22 12:24:48 EDT 
I have reverted the changes for bug#381974 for now.  I will try to figure out another solution for that bug.

http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=696a1204ff8dba220d9de477698bf409a32468b6