Bug 391370 - Use gtk_selection_data_get* functions instead of GtkSelectionData struct
Summary: Use gtk_selection_data_get* functions instead of GtkSelectionData struct
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.3   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.3 M3   Edit
Assignee: Alexander Kurtakov CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 340067
  Show dependency tree
 
Reported: 2012-10-08 15:25 EDT by Alexander Kurtakov CLA
Modified: 2012-10-18 12:05 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kurtakov CLA 2012-10-08 15:25:07 EDT 
Struct members should not be accessed directly and using the members will allow to remove the memmove/sizeof bindings for GtkSelectionData which fail to compile on GTK 3.x.
Comment 2 Markus Keller CLA 2012-10-18 05:43:03 EDT 
Since this commit, 4 SWT tests fail on GTK 64, see N-builds:

java.lang.UnsatisfiedLinkError: org.eclipse.swt.internal.gtk.OS._gtk_selection_data_get_target(J)J
at org.eclipse.swt.internal.gtk.OS._gtk_selection_data_get_target(Native Method)
at org.eclipse.swt.internal.gtk.OS.gtk_selection_data_get_target(OS.java:9960)
at org.eclipse.swt.dnd.ClipboardProxy.getFunc(ClipboardProxy.java:126)
at org.eclipse.swt.internal.gtk.OS._gtk_clipboard_wait_for_contents(Native Method)
at org.eclipse.swt.internal.gtk.OS.gtk_clipboard_wait_for_contents(OS.java:6164)
at org.eclipse.swt.dnd.Clipboard.gtk_clipboard_wait_for_contents(Clipboard.java:677)
at org.eclipse.swt.dnd.Clipboard.getContents(Clipboard.java:294)
at org.eclipse.swt.dnd.Clipboard.getContents(Clipboard.java:241)
at org.eclipse.swt.tests.junit.Test_org_eclipse_swt_custom_StyledText.test_copy(Test_org_eclipse_swt_custom_StyledText.java:555)
at org.eclipse.swt.tests.junit.Test_org_eclipse_swt_custom_StyledText.runTest(Test_org_eclipse_swt_custom_StyledText.java:4550)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:650)
Comment 3 Alexander Kurtakov CLA 2012-10-18 05:52:44 EDT 
Can this be a dup of bug#392214? I do work on 64 bit systems and can't reproduce.
Comment 4 Alexander Kurtakov CLA 2012-10-18 05:59:43 EDT 
I think it is . Looking at http://git.eclipse.org/c/platform/eclipse.platform.swt.binaries.git/commit/?id=ea7edb4da04487e4ffe11b9d95d1ee853b5c9daf x86_64 so file is not changed/rebuild.
Comment 5 Markus Keller CLA 2012-10-18 08:27:20 EDT 
> I do work on 64 bit systems and can't reproduce.

I guess that's with locally-built libraries, right? I can't test it since I don't have a 64 bit GTK.

I agree it's most probably bug 392214. I was puzzled because everything looked right in master.
Comment 6 Alexander Kurtakov CLA 2012-10-18 08:29:39 EDT 
(In reply to comment #5)
> > I do work on 64 bit systems and can't reproduce.
> 
> I guess that's with locally-built libraries, right? I can't test it since I
> don't have a 64 bit GTK.
> 
> I agree it's most probably bug 392214. I was puzzled because everything
> looked right in master.

Yes,locally build libraries and yes I see the failure with nightlies let's wait for the rebuilds to happen.