Bug 391255 - MenuManager.update called twice when showing a menu
Summary: MenuManager.update called twice when showing a menu
Status: CLOSED DUPLICATE of bug 375826
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2012-10-05 13:03 EDT by Karen Butzke CLA
Modified: 2012-10-05 15:13 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karen Butzke CLA 2012-10-05 13:03:21 EDT 
While trying to understand the fix for bug 389335, I noticed that MenuManager.update(boolean, boolean) is being called twice for menus with dynamic items in them.

MenuManagerRendererFilter.showMenu(Event, Menu, MMenu, MenuManager) calls the MenuManager.handleAboutToShow() method which calls MenuManager.update(false, false). Then the very last line of MenuManagerRefndererFilter.showMenu calls MenuManager.update(false) thus calling that method twice.

The ShowViewMenu class was modified to fix a leak in bug 389335. With this bug, ShowViewMenu.Fill(Menu, index) gets called twice so the MenuManager gets created twice.
Comment 1 Karen Butzke CLA 2012-10-05 15:13:01 EDT 
Sorry, my target workspace is outdated. This problem was fixed with the changes Paul made for bug 375826. Once I imported some of the projects into my workspace and had the latest 4.2.2 code, the problem went away :)

*** This bug has been marked as a duplicate of bug 375826 ***