Community
Participate
Working Groups
so, it is very nice to be notified about task submition changes (TaskJobListener), how ever, so far i couldn't get a hold of the changed taskData object that is about to be posted to the server. This code will get only the old taskAttributes (and obviously adds dependency on the UI plugin) TasksUi.getTaskDataManager().getTaskData(event.getTask()).getRoot(); that will be overwritten when the task is submitted. so, my question is: is it possible / would it make sense to you too: to supply the taskData reference for the TaskJobListener (eg.: in the TaskJobEvent) which will be submited to the repository? thank you for your consideration
That sounds reasonable idea to me. Would you be able to push a change to Gerrit with the proposed implementation?
Created attachment 221988 [details] patch cut against the master of task git repo i am sorry but i couldn't set up this whole gerrit thing. however here is my patch on top of commit 3f5048053279a0b69ec70deba5a3e4a06a4ee467 in the mylyn.tasks repo can you please look at/push this to gerrit? thanks Endre
I have pushed this to Gerrit: 8155: 390529: make taskData available in TaskJobListener methods [I67c2d79d] https://git.eclipse.org/r/#change,8155
Endre, what kind of problems did you run into when configuring Gerrit? Please post to mylyn-integrators or to this bug if there is anything we can help with. I have commented on the code review.
i managed to set up my environment and able to push to gerrit. i pushed the required changes. please review it @ https://git.eclipse.org/r/#/c/8155/ thanks Endre
The changes have been merged. Thanks very much for the contribution! Leaving this open to cherry-pick.
Closing and tagging with [backport].
Cherry-picked to 3.11 branch.
